From: Jeff Garzik <jgarzik@pobox.com>
To: Andreas Herrmann <AHERRMAN@de.ibm.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [Patch] dont block device on QUEUE_FULL for last command
Date: Tue, 05 Aug 2003 09:08:05 -0400 [thread overview]
Message-ID: <3F2FAC35.3060509@pobox.com> (raw)
In-Reply-To: <OF9404399C.2F79915F-ONC1256D79.00285DC0@de.ibm.com>
Andreas Herrmann wrote:
> Jeff Garzik <jgarzik@pobox.com>
>>For most cases you _should_ block until another command is completed, at
>>the very least. Retrying the command immediately is _exactly_ the
>>situation one wishes to avoid, when returning a QUEUE_FULL result!
> ... until another command is completed ...
>
> ... which will never happen, because there was a QUEUE_FULL for the
> last command for the device. The device will be blocked. No further
> commands are sent. Bad luck?
No; if driver does not complete (i.e. error out) commands in a timely
manner, that's a driver bug.
Thus, the queue should stay blocked until another command is completed,
because, not completing a command would be wrong :)
Jeff
next prev parent reply other threads:[~2003-08-05 13:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-05 7:26 [Patch] dont block device on QUEUE_FULL for last command Andreas Herrmann
2003-08-05 13:08 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-08-05 7:15 Andreas Herrmann
2003-08-04 15:42 Andreas Herrmann
2003-08-04 15:48 ` Jeff Garzik
2003-08-05 6:07 ` Jens Axboe
2003-08-11 8:45 ` Kurt Garloff
2003-08-04 16:05 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F2FAC35.3060509@pobox.com \
--to=jgarzik@pobox.com \
--cc=AHERRMAN@de.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.