All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: nfs@lists.sourceforge.net, linux-kernel <linux-kernel@vger.kernel.org>
Subject: [NFS] [PATCH] kNFSd: Fixes a problem with inode clean up for vxfs
Date: Wed, 06 Aug 2003 12:11:16 -0400	[thread overview]
Message-ID: <3F3128A4.8030305@RedHat.com> (raw)

This a patch I've received from Veritas. Supposedly they have
already submitted this but I can't seem to find it in any 2.4 trees..

Does anybody recognize this and are there any known issues with it?

The Problem: The nfsd_findparent creates a dentry using d_alloc_root. 
The d_op
vector pointer in this dentry is not initialized. Hence filesystems that 
supply
the vector have a problem. nfs exports of such filesystems do not work
correctly under memory pressure.  vxfs, vfat, ntfs are amongst the 
filesystems
affected by the bug.  Need redhat to fix nfsd code in their kernels. 
Ideally
a kernel needs to ask a filesystem to setup a d_op vector.  An entry point
into a filesystem for doing this job doesn't exist. We can work around the
problem by copying d_op vector pointer from the child of the dentry, whose
d_op vector is correct.


The Patch:

--- ./fs/nfsd/nfsfh.c.diff      Wed Jul  2 13:17:35 2003
+++ ./fs/nfsd/nfsfh.c   Tue Jul 29 04:45:43 2003
@@ -303,6 +303,7 @@ struct dentry *nfsd_findparent(struct de
                       if (pdentry) {
                               igrab(tdentry->d_inode);
                               pdentry->d_flags |= 
DCACHE_NFSD_DISCONNECTED;
+                              pdentry->d_op = child->d_op;
                       }
               }
               if (pdentry == NULL)

SteveD.

             reply	other threads:[~2003-08-06 16:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-06 16:11 Steve Dickson [this message]
2003-08-06 16:26 ` [NFS] [PATCH] kNFSd: Fixes a problem with inode clean up for vxfs Arjan van de Ven
2003-08-06 23:30   ` Neil Brown
2003-08-06 23:30     ` [NFS] " Neil Brown
2003-08-06 17:08 ` Rik van Riel
2003-08-06 23:29 ` Neil Brown
2003-08-06 23:29   ` [NFS] " Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F3128A4.8030305@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@cse.unsw.edu.au \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.