All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Dave Jones <davej@redhat.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove useless assertions from reiserfs
Date: Mon, 11 Aug 2003 13:56:23 -0400	[thread overview]
Message-ID: <3F37D8C7.5050906@pobox.com> (raw)
In-Reply-To: <20030811175237.GA1402@redhat.com>

Dave Jones wrote:
> On Mon, Aug 11, 2003 at 01:45:30PM -0400, Jeff Garzik wrote:
>  > Why are these useless?
> 
> read the code not the diff.
> 
>  > >@@ -90,10 +90,6 @@ u32 keyed_hash(const signed char *msg, i
>  > > 
>  > > 	if (len >= 12)
>  > > 	{
>  > >-	    	//assert(len < 16);
>  > >-		if (len >= 16)
>  > >-		    BUG();
>  > >-
>  > > 		a = (u32)msg[ 0]      |
>  > > 		    (u32)msg[ 1] << 8 |
>  > > 		    (u32)msg[ 2] << 16|
>  > 
>  > Seems like a valid check to me...
> 
> Above this loop is another loop which we don't exit until len < 16

ok, agreed

	Jeff





  reply	other threads:[~2003-08-11 17:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-11 16:48 [PATCH] Remove useless assertions from reiserfs davej
2003-08-11 17:45 ` Jeff Garzik
2003-08-11 17:52   ` Dave Jones
2003-08-11 17:56     ` Jeff Garzik [this message]
2003-08-11 18:00   ` Valdis.Kletnieks
  -- strict thread matches above, loose matches on Subject: below --
2003-08-11 18:33 Petr Vandrovec
2003-08-11 18:46 ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F37D8C7.5050906@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.