From: Stephane Ouellette <ouellettes@videotron.ca>
To: Harald Welte <laforge@netfilter.org>
Cc: netfilter-devel@lists.netfilter.org
Subject: [PATCH] Less printf() calls for libip6t_esp.c
Date: Tue, 12 Aug 2003 14:08:12 -0400 [thread overview]
Message-ID: <3F392D0C.7080104@videotron.ca> (raw)
[-- Attachment #1: Type: text/plain, Size: 137 bytes --]
Harald,
this attached patch contains C99 initializers and printf()
simplifications fo libip6t_esp.c.
Please apply.
Stephane
[-- Attachment #2: libip6t_esp.c.patch --]
[-- Type: text/plain, Size: 1664 bytes --]
--- netfilter.orig/userspace/extensions/libip6t_esp.c Wed May 29 09:08:16 2002
+++ netfilter/userspace/extensions/libip6t_esp.c Mon Aug 11 21:57:45 2003
@@ -19,8 +19,8 @@
}
static struct option opts[] = {
- { "espspi", 1, 0, '1' },
- {0}
+ { .name = "espspi", .has_arg = 1, .flag = 0, .val = '1' },
+ { .name = 0 }
};
static u_int32_t
@@ -29,7 +29,7 @@
unsigned long int spi;
char* ep;
- spi = strtoul(spistr,&ep,0) ;
+ spi = strtoul(spistr, &ep, 0);
if ( spistr == ep ) {
exit_error(PARAMETER_PROBLEM,
@@ -117,17 +117,10 @@
const char *inv = invert ? "!" : "";
if (min != 0 || max != 0xFFFFFFFF || invert) {
- printf("%s", name);
- if (min == max) {
- printf(":%s", inv);
- printf("%u", min);
- } else {
- printf("s:%s", inv);
- printf("%u",min);
- printf(":");
- printf("%u",max);
- }
- printf(" ");
+ if (min == max)
+ printf("%s:%s%u ", name, inv, min);
+ else
+ printf("%ss:%s%u:%u ", name, inv, min, max);
}
}
@@ -168,19 +161,18 @@
}
static
-struct ip6tables_match esp
-= { NULL,
- "esp",
- IPTABLES_VERSION,
- IP6T_ALIGN(sizeof(struct ip6t_esp)),
- IP6T_ALIGN(sizeof(struct ip6t_esp)),
- &help,
- &init,
- &parse,
- &final_check,
- &print,
- &save,
- opts
+struct ip6tables_match esp = {
+ .name = "esp",
+ .version = IPTABLES_VERSION,
+ .size = IP6T_ALIGN(sizeof(struct ip6t_esp)),
+ .userspacesize = IP6T_ALIGN(sizeof(struct ip6t_esp)),
+ .help = &help,
+ .init = &init,
+ .parse = &parse,
+ .final_check = &final_check,
+ .print = &print,
+ .save = &save,
+ .extra_opts = opts
};
void
next reply other threads:[~2003-08-12 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-12 18:08 Stephane Ouellette [this message]
2003-08-23 18:42 ` [PATCH] Less printf() calls for libip6t_esp.c Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F392D0C.7080104@videotron.ca \
--to=ouellettes@videotron.ca \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.