All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Courtier-Dutton <James@superbug.demon.co.uk>
To: alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: [PATCH] Fixes ac3 passthru non-audio bit setting for AC97 codecs.
Date: Thu, 14 Aug 2003 16:16:03 +0100	[thread overview]
Message-ID: <3F3BA7B3.3010901@superbug.demon.co.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

I have :-
Card: Intel ICH5
Chip: Avance Logic ALC650 rev 0

The problem I was having was that the spdif "non-audio" bit was not 
being set.
This patch fixes that problem.

Cheers
James

[-- Attachment #2: ac3_passthru_fix.diff --]
[-- Type: text/plain, Size: 604 bytes --]

--- ac97_codec.c.org	2003-08-14 14:19:29.834681728 +0100
+++ ac97_codec.c	2003-08-14 16:11:39.736581128 +0100
@@ -823,7 +825,13 @@
 					       AC97_CXR_SPDIF_MASK | AC97_CXR_COPYRGT,
 					       v);
 	} else {
+		unsigned short extst = ac97->regs[AC97_EXTENDED_STATUS];
+		snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, 0); /* turn off */
+
 		change |= snd_ac97_update_bits(ac97, AC97_SPDIF, 0x3fff, val);
+		if (extst & AC97_EA_SPDIF) {
+			snd_ac97_update_bits(ac97, AC97_EXTENDED_STATUS, AC97_EA_SPDIF, AC97_EA_SPDIF); /* turn on again */
+                }
 	}
 
 	return change;

             reply	other threads:[~2003-08-14 15:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-14 15:16 James Courtier-Dutton [this message]
2003-08-14 16:05 ` [PATCH] Fixes ac3 passthru non-audio bit setting for AC97 codecs Takashi Iwai
2003-08-14 16:49   ` Gregoire Favre
2003-08-14 17:23     ` Takashi Iwai
2003-08-14 17:44     ` James Courtier-Dutton
2003-08-14 20:48       ` Gregoire Favre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F3BA7B3.3010901@superbug.demon.co.uk \
    --to=james@superbug.demon.co.uk \
    --cc=alsa-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.