From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven French Subject: missing code in fcntl_dirnotify Date: Fri, 15 Aug 2003 21:35:48 -0500 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <3F3D9884.9000CC8E@austin.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from ms-smtp-03.texas.rr.com ([24.93.36.231]:56253 "EHLO ms-smtp-03.texas.rr.com") by vger.kernel.org with ESMTP id S272533AbTHPClF (ORCPT ); Fri, 15 Aug 2003 22:41:05 -0400 To: linux-fsdevel@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org I noticed that fcntl_dirnotify in fs/dnotify.c is missing logic to call an optional fs specific inode operation for file/directory notify. Since directory and file notification to make any sense for many filesystems (especially network ones) would require that this call (fcntl F_NOTIFY) to pass through to the filesystem who owns the inode (to let the particular filesystem know it has to call dnotify_parent on remote updates to the file/directory) it seems like a bug. Without notification to the underlying network filesystem, it can not know to read the updated inode->i_dnotify_mask Is there any objection why dnotify_parent should not be added to ksysm.c and to adding an optional inode_operation for change_notify so filesystems that can support change notify (cifs, nfs, presumably afs etc.) could do change notify to the proper kernel routine(dnotify_parent)?