From: Jeff Garzik <jgarzik@pobox.com>
To: mzyngier@freesurf.fr
Cc: akpm@osdl.org, linux-net@vger.kernel.org,
Maillist netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH][2.6] de4x5 cleanup
Date: Sat, 30 Aug 2003 13:50:53 -0400 [thread overview]
Message-ID: <3F50E3FD.1000703@pobox.com> (raw)
In-Reply-To: <wrpad9r79g6.fsf@hina.wild-wind.fr.eu.org>
Marc Zyngier wrote:
> Jeff, Andrew,
>
> The enclosed patch tries to clean the tulip de4x5 driver, and update
> it to some of the 2.6 APIs :
>
> - Use PCI and EISA probing APIs
> - Use generic DMA API
> - Fix DE425 init on the Jensen
> - Remove de4x5 from Space.c
>
> It's been tested on x86 and Alpha, with a DE425 (21040, EISA), a DE435
> (21040, PCI) and a quad DLink (4*21143, PCI).
>
> The major problem with this patch is that, because of the Space.c
> removal, interfaces get potentially renumbered. This has been
> discussed to death on lkml, without any obvious solution. IMHO, we'd
> better remove as many drivers as we can from Space.c before
> 2.6.0-final ships...
It looks pretty good. My big objection isn't the Space.c stuff but
de4x5 itself. I had hoped it would be gone by now :) Oh well, not your
fault.
A quick review of the patch looks good, and this is work that has long
wanted doing (if de4x5 wasn't simply erased). I'll apply after a more
thorough review.
Jeff
next parent reply other threads:[~2003-08-30 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <wrpad9r79g6.fsf@hina.wild-wind.fr.eu.org>
2003-08-30 17:50 ` Jeff Garzik [this message]
2003-08-30 19:04 ` [PATCH][2.6] de4x5 cleanup Marc Zyngier
2003-08-30 19:16 ` Jeff Garzik
2003-08-30 21:22 ` Marc Zyngier
2003-08-31 9:31 ` de2104x (was Re: [PATCH][2.6] de4x5 cleanup) Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F50E3FD.1000703@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-net@vger.kernel.org \
--cc=mzyngier@freesurf.fr \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.