From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Marcelo Tosatti <marcelo@parcelfarce.linux.theplanet.co.uk>,
"J.A. Magallon" <jamagallon@able.es>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] check_gcc for i386
Date: Sat, 30 Aug 2003 20:47:55 -0400 [thread overview]
Message-ID: <3F5145BB.5080906@pobox.com> (raw)
In-Reply-To: <1062286661.31332.8.camel@dhcp23.swansea.linux.org.uk>
Alan Cox wrote:
> On Sad, 2003-08-30 at 23:58, Marcelo Tosatti wrote:
>
>>> ifdef CONFIG_MPENTIUM4
>>>-CFLAGS += -march=i686
>>>+CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
>>> endif
>>>
>>> ifdef CONFIG_MK6
>>
>>OK, I forgot what that does. Can you please explain in detail what
>>check_gcc does.
>
>
> Tries to use gcc with the options given and if not falls back to the
> second set suggested. So it'll try -march=pentium4 (new gcc) and
> fall back to -march=i686
Yep. I introduced check_gcc into 2.4 (backported from 2.5), in fact.
The above change does exactly what Alan describes, and is a patch I was
planning to submit myself :) I did not want to change compiler options
at the time when I submitted the check_gcc patch, but after many months
of manually patching to get the best compiler flags, it seems solid.
Jeff
next prev parent reply other threads:[~2003-08-31 0:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-30 15:48 Linux 2.4.23-pre2 Marcelo Tosatti
2003-08-30 16:22 ` Dave Bentham
2003-08-30 19:35 ` system_lists
2003-08-30 22:05 ` [PATCH] check_gcc for i386 J.A. Magallon
2003-08-30 22:58 ` Marcelo Tosatti
2003-08-30 23:20 ` Norberto BENSA
2003-08-31 2:39 ` Marcelo Tosatti
2003-08-30 23:31 ` J.A. Magallon
2003-08-30 23:37 ` Alan Cox
2003-08-31 0:47 ` Jeff Garzik [this message]
2003-08-31 0:59 ` Kurt Wall
2003-08-31 3:03 ` Marcelo Tosatti
2003-09-01 19:14 ` Marcelo Tosatti
2003-08-30 23:01 ` Andre Tomt
2003-08-30 23:11 ` Linux 2.4.23-pre2 - airo.c compile failure Eyal Lebedinsky
2003-09-03 15:56 ` [patch] fix airo.c compile failure with gcc 2.95 Adrian Bunk
2003-09-03 16:33 ` Jeff Garzik
2003-08-31 9:21 ` [PATCH] correct AT_PLATFORM for HT cpus J.A. Magallon
2003-09-02 15:18 ` [patch] 2.4.23-pre2: fix rocket.c compilation Adrian Bunk
2003-09-02 16:49 ` 2.4.23-pre2: 3c515.c doesn't compile non-modular Adrian Bunk
2003-09-02 17:47 ` [PATCH] " Jeff Garzik
2003-10-15 17:32 ` airo regression with Linux 2.4.23-pre2 Udo A. Steinberg
2003-10-15 19:47 ` Celso González
2003-10-15 21:27 ` Javier Achirica
2003-10-16 13:51 ` Udo A. Steinberg
2003-10-16 14:52 ` Marc Giger
2003-10-19 15:19 ` Joseph Pingenot
2003-10-20 10:33 ` Javier Achirica
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F5145BB.5080906@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=marcelo@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.