From: Jeff Garzik <jgarzik@pobox.com>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: Re: The recent free_netdev() conversion...
Date: Mon, 01 Sep 2003 11:58:47 -0400 [thread overview]
Message-ID: <3F536CB7.6060404@pobox.com> (raw)
In-Reply-To: <20030901075345.4c35e3e6.davem@redhat.com>
David S. Miller wrote:
> On Mon, 01 Sep 2003 10:59:09 -0400
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>
>> err_out:
>> kfree(dev);
>
> ...
>
>>The "kfree" needs to be a free_netdev() too.
>
>
> If the 'dev' hasn't been given to register_netdev() it
> really doesn't need to be free_netdev(). It's just memory
> until it has been given to the device layer.
True, but for long term, it's best to use free_netdev(). Besides
naturally pairing with alloc_foodev(), if we ever decide to have
alloc_netdev() perform more than one allocation, free_netdev() will
already be in place to handle the multiple de-allocations.
Jeff
next prev parent reply other threads:[~2003-09-01 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-01 14:59 The recent free_netdev() conversion Jeff Garzik
2003-09-01 14:53 ` David S. Miller
2003-09-01 15:58 ` Jeff Garzik [this message]
2003-09-01 15:58 ` David S. Miller
2003-09-03 22:33 ` [PATCH] 2.6.0-test4-bk5 - Was: " Francois Romieu
2003-09-04 0:56 ` Jeff Garzik
2003-09-04 3:35 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F536CB7.6060404@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.