From: "Kip Walker" <kwalker@broadcom.com>
To: linux-mips@linux-mips.org
Subject: [PATCH] sibyte patch for 2.6 ide.h
Date: Wed, 03 Sep 2003 16:46:18 -0700 [thread overview]
Message-ID: <3F567D4A.BA3FD396@broadcom.com> (raw)
Folks,
Any objection to the following patch, which lets IDE work on 2.6 for
SiByte platforms? Before getting it checked in, I'm willing to hear
style comments. I need extra work to happen in ide_init_default_hwifs,
but that code doesn't fit well in <asm/ide.h> because most of the useful
declarations in <linux/ide.h> haven't been made yet. With this patch, I
hoist the code into a C file, but can call back into the existing code
(avoiding maintaining a duplicate).
Kip
Index: include/asm-mips/ide.h
===================================================================
RCS file: /home/cvs/linux/include/asm-mips/ide.h,v
retrieving revision 1.22
diff -u -r1.22 ide.h
--- include/asm-mips/ide.h 21 Jun 2003 14:08:28 -0000 1.22
+++ include/asm-mips/ide.h 3 Sep 2003 23:42:16 -0000
@@ -50,7 +50,12 @@
ide_ops->ide_init_hwif_ports(hw, data_port, ctrl_port, irq);
}
+#ifdef CONFIG_SIBYTE_SB1xxx_SOC
+extern void ide_init_default_hwifs(void);
+static __inline__ void mips_ide_init_default_hwifs(void)
+#else
static __inline__ void ide_init_default_hwifs(void)
+#endif
{
#ifndef CONFIG_PCI
hw_regs_t hw;
next reply other threads:[~2003-09-03 23:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-03 23:46 Kip Walker [this message]
2003-09-05 16:57 ` [PATCH] sibyte patch for 2.6 ide.h Maciej W. Rozycki
2003-09-05 17:08 ` Kip Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F567D4A.BA3FD396@broadcom.com \
--to=kwalker@broadcom.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.