Re: [PATCH] AES i586-asm optimized

[Jeff Garzik <jgarzik@pobox.com>]

Jari Ruusu wrote:
> Jeff Garzik wrote:
> 
>>On Wed, Sep 10, 2003 at 05:38:59PM +0200, Fruhwirth Clemens wrote:
>>
>>>As tested by hvr[2] this implemention is significantly faster than the C
>>>version.
>>
>>Tested on what processors?  With what kernel config?
>>
>>I would be surprised if a 586-optimized asm was useful on P4.
> 
> 
> It uses classic Pentium instruction set. Speed optimized for my 300 MHz
> Pentium-2 test box. Original Gladman version that I started with was pretty
> fast but I was able to improve performance about 7% over original version.
> 
> On my same 300 MHz P2 test box, assembler implementation is about twice as
> fast as the mainline kernel C implementation.


Neat.  Consider me surprised, then  ;-)

Don't take my message as objection to the merge.  I dunno what DaveM or 
JamesM thinks, but I definitely support merging patches like this.  It 
provides a great example, if nothing else.

Eventually I bet there will be issues about automatic algorithm 
selection:  like the RAID5 code, which benchmarks all available 
algorithms, and selects the fastest one.

	Jeff