All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390 (6/7): network drivers.
Date: Thu, 11 Sep 2003 16:16:58 -0400	[thread overview]
Message-ID: <3F60D83A.9060506@pobox.com> (raw)
In-Reply-To: <20030911171747.GG5637@mschwid3.boeblingen.de.ibm.com>

Martin Schwidefsky wrote:

> -	spin_lock_init(&card->wait_q_lock);
> +	/* setup net_device stuff */
> +	card->dev->priv = card;
> +
> +	strncpy(card->dev->name, card->dev_name, IFNAMSIZ);

what's this about?  Why avoid the net stack's dev->name assignment?



> +	QETH_DBF_TEXT3(0, trace, "alloccrd");
> +	card = (struct qeth_card *) vmalloc(sizeof (struct qeth_card));
> +	if (!card)
> +		return NULL;

Is the card's private info really so large that you need vmalloc() ?

Most of the patch looks ok to me, except for these minor niggles.

	Jeff






  reply	other threads:[~2003-09-11 20:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-11 17:17 [PATCH] s390 (6/7): network drivers Martin Schwidefsky
2003-09-11 20:16 ` Jeff Garzik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-09-12  8:45 Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F60D83A.9060506@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.