From: Jeff Garzik <jgarzik@pobox.com>
To: Bernhard Rosenkraenzer <bero@arklinux.org>
Cc: Samuel Flory <sflory@rackable.com>, linux-kernel@vger.kernel.org
Subject: Re: [FIX] Re: 2.4.23-pre3-pac2 broke PIIX ata-scsi
Date: Fri, 12 Sep 2003 22:45:23 -0400 [thread overview]
Message-ID: <3F6284C3.306@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.56.0309130130050.17972@dot.kde.org>
Bernhard Rosenkraenzer wrote:
> Since this is probably the first version of ATA_PIIX that does compile
> with modular SCSI, I'd like some feedback on whether or not it actually
> works w/ modular SCSI (I don't have any test hardware).
Red Hat ships it modular. This version of libata of woefully out of
date. I need to get you an update :)
> diff -urN linux-2.4.23-pre3-pac2/drivers/scsi/Config.in linux-2.4.23-pre3-pac3/drivers/scsi/Config.in
> --- linux-2.4.23-pre3-pac2/drivers/scsi/Config.in 2003-09-13 02:35:08.000000000 +0200
> +++ linux-2.4.23-pre3-pac3/drivers/scsi/Config.in 2003-09-13 02:41:35.000000000 +0200
> @@ -71,7 +71,7 @@
> dep_tristate 'AMI MegaRAID support (new driver)' CONFIG_SCSI_MEGARAID2 $CONFIG_SCSI
> fi
>
> -dep_bool 'SATA support' CONFIG_SCSI_ATA $CONFIG_SCSI
> +dep_tristate 'SATA support' CONFIG_SCSI_ATA $CONFIG_SCSI
This is not correct. It should "dep_mbool".
> diff -urN linux-2.4.23-pre3-pac2/include/linux/ata.h linux-2.4.23-pre3-pac3/include/linux/ata.h
> --- linux-2.4.23-pre3-pac2/include/linux/ata.h 2003-09-13 02:35:11.000000000 +0200
> +++ linux-2.4.23-pre3-pac3/include/linux/ata.h 2003-09-13 02:41:51.000000000 +0200
> @@ -629,13 +629,6 @@
> return status;
> }
>
> -/*
> - * 2.5 compat.
> - */
> -
> -typedef void irqreturn_t;
> -#define IRQ_RETVAL(x) /* nothing */
> -
Yes, this is what I have checked in locally.
Once I return from a conference next week, I'll send you an update patch
specific with -pac kernels...
Jeff
prev parent reply other threads:[~2003-09-13 2:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-11 12:53 2.4.23-pre3-pac2 Bernhard Rosenkraenzer
2003-09-11 15:29 ` 2.4.23-pre3-pac2 Alan Cox
2003-09-11 16:17 ` 2.4.23-pre3-pac2 Bernhard Rosenkraenzer
2003-09-12 23:20 ` 2.4.23-pre3-pac2 broke PIIX ata-scsi Samuel Flory
2003-09-13 1:02 ` [FIX] " Bernhard Rosenkraenzer
2003-09-13 2:45 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F6284C3.306@pobox.com \
--to=jgarzik@pobox.com \
--cc=bero@arklinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sflory@rackable.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.