Re: [PATCH] add likely around access_ok for uaccess

[Manfred Spraul <manfred@colorfullife.com>]

Manfred Spraul wrote:

> Andrew Morton wrote:
>
>> +#define access_ok(type,addr,size) (likely(__range_ok(addr,size) == 0))
>>  
>>
> I don't know. What happens if access_ok is used outside of an if 
> statement?
> One example is
>
> int get_compat_timespec(struct timespec *ts, struct compat_timespec *cts)
> {
>        return (verify_area(VERIFY_READ, cts, sizeof(*cts)) ||
>                        __get_user(ts->tv_sec, &cts->tv_sec) ||
>                        __get_user(ts->tv_nsec, &cts->tv_nsec)) ? 
> -EFAULT : 0;
> }

Duh. Reading is difficult.
The functions with access_ok are get_compat_itimerval and 
put_compat_itimerval.

--
    Manfred