From: Gianluca <gcosta@libero.it>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Re: Patch s3c2410 nand-boot.
Date: Thu, 18 Sep 2003 14:09:50 +0200 [thread overview]
Message-ID: <3F69A08E.2000907@libero.it> (raw)
In-Reply-To: <20030918103204.E5111C59E4@atlas.denx.de>
Wolfgang Denk wrote:
> Dear Gianluca,
>
> in message <3F68D1DF.7020007@libero.it> you wrote:
>
>>I send you my patch for s3c2410 ARM processor. This patch implements
>>boot directly from nandflash. I haven't created new board in board
>>directory but I have writed new config-file (smdk2410nand.h) that use
>>smdk2410 board.
>
>
> I have forwarded your patch to David M?ller who is the maintainer for
> the SMDK2410 board; I cannot test it myself.
>
>
>>I tested with MAKEALL ARM9 my patch.
>>I changed the frequency of internal clock of s3c2410 (for smdk2410
>>borad) because (only) in this way the Linux Mizi kernel can boot correctly.
>>The patch is based on u-boot 0.4.8.
>>
>>This is my first contribution to open source and I hope that it is
>>useful to someone.
>
>
> It is definitely useful, but I have a couple of questions:
>
> * Which problem are you trying to address which is not supported by
> the existing NAND code?
I have changed NAND code only to remove warning beacuse I don't use
some variable an then I rewrite "unsigned long nandptr = nand->IO_ADDR;" in
"unsigned long nandptr; nandptr = nand->IO_ADDR;".
>
> * Is it necessary to implement this in a processor specific way?
The boot from nand (without flash) is specific of s3c2410 cpu and so I
rewrite some part of cpu/arm920t/start.S (reset and copy from nand to ram).
>
> * You add new configuration options like CONFIG_S3C2410_NAND_BOOT but
> do not include any dosumentation. At least, please provide an
> explantion of these options for the README fie. If you feel longer
> explanations are needed create a new file doc/README.NAND-Boot or
> so.
>
I have forgot!
When you want boot from nand-flash and not from frash you have to define
CONFIG_S3C2410_NAND_BOOT in your conifg file. This define is independent
to u-boot NAND support.
>
> David, I've forwarded the patch to you. Can you please have a look at
> the implementation details? Thanks.
>
> Best regards,
>
> Wolfgang Denk
>
Bye
Ginaluca
next prev parent reply other threads:[~2003-09-18 12:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3F68D1DF.7020007@libero.it>
2003-09-18 10:31 ` [U-Boot-Users] Re: Patch s3c2410 nand-boot Wolfgang Denk
2003-09-18 12:09 ` Gianluca [this message]
2003-09-19 10:15 ` "David Müller (ELSOFT AG)"
2003-09-19 20:14 ` Wolfgang Denk
2003-09-22 13:22 ` Matt Matoushek
2003-09-20 13:57 Woodruff, Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F69A08E.2000907@libero.it \
--to=gcosta@libero.it \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.