From: Diadon <diadon@isfera.ru>
To: Harald Welte <laforge@netfilter.org>
Cc: David Miller <davem@redhat.com>,
Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.4] fix ipt_REJECT when used in OUTPUT
Date: Mon, 22 Sep 2003 12:16:50 +0400 [thread overview]
Message-ID: <3F6EAFF2.9080303@isfera.ru> (raw)
In-Reply-To: <20030921144013.GA22223@sunbeam.de.gnumonks.org>
That patch is not work, after patching the kernel problem is not
disappeared!
Patch by Patrick is working fine and fix this problem
Harald Welte wrote:
>Hi Dave!
>
>Some people use REJECT in the OUTPUT chain (rejecting locally generated
>packets). This didn't work anymore starting with some fixes we did in 2.4.22.
>A dst_entry for a local source doesn't contain pmtu information - and
>thus the newly-created packet would instantly be dropped again.
>
>I'll send you a 2.6.x merge for this later.
>
>Please apply the following fix, thanks
>
>
>
>------------------------------------------------------------------------
>
>diff -Nru --exclude .depend --exclude '*.o' --exclude '*.ko' --exclude '*.ver' --exclude '.*.flags' --exclude '*.orig' --exclude '*.rej' --exclude '*.cmd' --exclude '*.mod.c' --exclude '*~' linux-2.4.22/net/ipv4/netfilter/ipt_REJECT.c linux-2.4.22-rejectfix/net/ipv4/netfilter/ipt_REJECT.c
>--- linux-2.4.22/net/ipv4/netfilter/ipt_REJECT.c 2003-08-25 13:44:44.000000000 +0200
>+++ linux-2.4.22-rejectfix/net/ipv4/netfilter/ipt_REJECT.c 2003-09-21 16:39:25.000000000 +0200
>@@ -186,8 +186,8 @@
> nskb->nh.iph->check = ip_fast_csum((unsigned char *)nskb->nh.iph,
> nskb->nh.iph->ihl);
>
>- /* "Never happens" */
>- if (nskb->len > nskb->dst->pmtu)
>+ /* dst->pmtu can be zero because it is not set for local dst's */
>+ if (nskb->dst->pmtu && nskb->len > nskb->dst->pmtu)
> goto free_nskb;
>
> connection_attach(nskb, oldskb->nfct);
>
>
>------------------------------------------------------------------------
>
>Scanned by evaliation version of Dr.Web antivirus Daemon
>http://drweb.ru/unix/
>
>
>
next prev parent reply other threads:[~2003-09-22 8:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-21 14:40 [PATCH 2.4] fix ipt_REJECT when used in OUTPUT Harald Welte
2003-09-22 1:16 ` David S. Miller
2003-09-22 8:16 ` Diadon [this message]
2003-09-22 8:53 ` Harald Welte
2003-09-22 9:02 ` David S. Miller
2003-09-22 11:13 ` Diadon
2003-09-22 12:21 ` Harald Welte
2003-09-23 19:43 ` David S. Miller
2003-09-22 11:08 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F6EAFF2.9080303@isfera.ru \
--to=diadon@isfera.ru \
--cc=davem@redhat.com \
--cc=laforge@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.