Re: {PATCH]: fix expectation eviction order

[Patrick McHardy <kaber@trash.net>]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

Harald Welte wrote:

>Committed to CVS now.
>
Status: Pending for kernel inclusion, needs testing

I may have changed a bit too much for a simple bugfix, since I wanted
to be sure to keep correct behaviour in case of multiple manglings
to one packet I just deleted and rewrote it. At that occasion I changed
the lookup stuff to list_for_each_entry ;) This patch is a little less
intrusive, IIRC Martin is working on the list stuff anyways so maybe
it's more appropriate.

Best regards,
Patrick


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 555 bytes --]

===== net/ipv4/netfilter/ip_conntrack_core.c 1.26 vs edited =====
--- 1.26/net/ipv4/netfilter/ip_conntrack_core.c	Mon Aug 25 22:38:24 2003
+++ edited/net/ipv4/netfilter/ip_conntrack_core.c	Wed Oct  1 04:46:05 2003
@@ -997,7 +997,7 @@
 		       NIPQUAD(related_to->tuplehash[IP_CT_DIR_ORIGINAL].tuple.dst.ip));
  
 		/* choose the the oldest expectation to evict */
-		list_for_each(cur_item, &related_to->sibling_list) { 
+		list_for_each_prev(cur_item, &related_to->sibling_list) { 
 			struct ip_conntrack_expect *cur;
 
 			cur = list_entry(cur_item,