From: Jeff Garzik <jgarzik@pobox.com>
To: Matt Mackall <mpm@selenic.com>
Cc: netdev@oss.sgi.com, Andrew Morton <akpm@osdl.org>
Subject: Re: [RFC] [PATCH 2/3] tg3 netpoll hook
Date: Sat, 04 Oct 2003 22:44:13 -0400 [thread overview]
Message-ID: <3F7F857D.5010504@pobox.com> (raw)
In-Reply-To: <20031003014505.GS1897@waste.org>
Matt Mackall wrote:
> l-mpm/drivers/net/tg3.c | 16 ++++++++++++++++
> 1 files changed, 16 insertions(+)
>
> diff -puN drivers/net/tg3.c~tg3-poll drivers/net/tg3.c
> --- l/drivers/net/tg3.c~tg3-poll 2003-09-25 11:47:30.000000000 -0500
> +++ l-mpm/drivers/net/tg3.c 2003-09-25 11:56:37.000000000 -0500
> @@ -2475,6 +2475,15 @@ static irqreturn_t tg3_interrupt(int irq
> static int tg3_init_hw(struct tg3 *);
> static int tg3_halt(struct tg3 *);
>
> +#ifdef HAVE_POLL_CONTROLLER
> +static void tg3_poll_controller(struct net_device *dev)
> +{
> + disable_irq(dev->irq);
> + tg3_interrupt (dev->irq, dev, NULL);
> + enable_irq(dev->irq);
> +}
> +#endif
> +
> static void tg3_reset_task(void *_data)
> {
> struct tg3 *tp = _data;
> @@ -7482,6 +7491,10 @@ static struct pci_dev * __devinit tg3_fi
> return peer;
> }
>
> +#ifdef HAVE_POLL_CONTROLLER
> +static void tg3_poll_controller(struct net_device *dev);
> +#endif
This prototype is pointless.
> @@ -7632,6 +7645,9 @@ static int __devinit tg3_init_one(struct
> dev->watchdog_timeo = TG3_TX_TIMEOUT;
> dev->change_mtu = tg3_change_mtu;
> dev->irq = pdev->irq;
> +#ifdef HAVE_POLL_CONTROLLER
> + dev->poll_controller = tg3_poll_controller;
> +#endif
>
> err = tg3_get_invariants(tp);
> if (err) {
>
> _
>
>
next prev parent reply other threads:[~2003-10-05 2:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-03 1:45 [RFC] [PATCH 2/3] tg3 netpoll hook Matt Mackall
2003-10-05 2:44 ` Jeff Garzik [this message]
2003-10-05 2:55 ` Matt Mackall
2003-10-05 3:11 ` Jeff Garzik
2003-10-05 3:16 ` Keith Owens
2003-10-05 3:21 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F7F857D.5010504@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=mpm@selenic.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.