All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Haverkamp <markh@osdl.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	James Bottomley <James.Bottomley@steeleye.com>,
	Mark Salyzyn <mark_salyzyn@adaptec.com>
Subject: Re: [PATCH 1/3] 2.6.0 aacraid driver update
Date: Mon, 06 Oct 2003 18:24:19 -0400	[thread overview]
Message-ID: <3F81EB93.7060303@pobox.com> (raw)
In-Reply-To: <1065478184.17021.85.camel@markh1.pdx.osdl.net>

Mark Haverkamp wrote:
> I'll go back over everything and fix and make the casting more
> consistent, as well as check over the code for all you other comments.
> 
> Thanks for looking this over.


Thanks.  FWIW I tend to prefer to rely on C type promotion to avoid 
cluttering up the code with explicit casts.  This wanders a bit into 
developer's personal style preferences, but OTOH excessive casting has 
led to bugs in the past...

	Jeff




  reply	other threads:[~2003-10-06 22:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-06 21:21 [PATCH 1/3] 2.6.0 aacraid driver update Mark Haverkamp
2003-10-06 21:55 ` Jeff Garzik
2003-10-06 22:09   ` Mark Haverkamp
2003-10-06 22:24     ` Jeff Garzik [this message]
2003-10-07 21:18   ` Mark Haverkamp
2003-10-07 21:39     ` Matthew Wilcox
2003-10-07 21:50       ` Mark Haverkamp
2003-10-07 21:39     ` Jeff Garzik
2003-10-08 17:43   ` Mark Haverkamp
  -- strict thread matches above, loose matches on Subject: below --
2003-10-08 13:11 Salyzyn, Mark
2003-10-08 13:55 ` Matthew Wilcox
2003-10-08 14:23 ` Mark Haverkamp
2003-10-08 14:26 Salyzyn, Mark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F81EB93.7060303@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mark_salyzyn@adaptec.com \
    --cc=markh@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.