From: Jeff Garzik <jgarzik@pobox.com>
To: Andi Kleen <ak@muc.de>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] Fix 64bit warnings in rtl8139too
Date: Tue, 14 Oct 2003 14:13:04 -0400 [thread overview]
Message-ID: <3F8C3CB0.9090502@pobox.com> (raw)
In-Reply-To: <20031007175638.GA1754@averell>
Andi Kleen wrote:
> Fix a harmless 64bit pointer/integer mismatch warning in 8139too.
>
> diff -u linux-2.5-cleanup/drivers/net/8139too.c-o linux-2.5-cleanup/drivers/net/8139too.c
> --- linux-2.5-cleanup/drivers/net/8139too.c-o 2003-09-08 00:02:03.000000000 +0200
> +++ linux-2.5-cleanup/drivers/net/8139too.c 2003-12-02 17:13:24.634752560 +0100
> @@ -746,7 +746,8 @@
> u8 tmp8;
> int rc;
> unsigned int i;
> - u32 pio_start, pio_end, pio_flags, pio_len;
> + unsigned long pio_start;
> + u32 pio_end, pio_flags, pio_len;
> unsigned long mmio_start, mmio_end, mmio_flags, mmio_len;
> u32 version;
Why not just make this look like mmio_*?
Jeff
next prev parent reply other threads:[~2003-10-14 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-07 17:56 [PATCH] Fix 64bit warnings in rtl8139too Andi Kleen
2003-10-14 18:13 ` Jeff Garzik [this message]
2003-10-14 19:49 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F8C3CB0.9090502@pobox.com \
--to=jgarzik@pobox.com \
--cc=ak@muc.de \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.