From: Ulrich Drepper <drepper@redhat.com>
To: "Carlos O'Donell" <carlos@baldric.uwo.ca>
Cc: libc-alpha <libc-alpha@sources.redhat.com>,
parisc-linux@lists.parisc-linux.org
Subject: [parisc-linux] Re: [PATCH] Sysdeps changes for hppa.
Date: Tue, 14 Oct 2003 22:49:10 -0700 [thread overview]
Message-ID: <3F8CDFD6.1010300@redhat.com> (raw)
In-Reply-To: <20031012213226.GE23999@systemhalted>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
> 2003-10-12 Carlos O'Donell <carlos@baldric.uwo.ca>
>
> * sysdeps/hppa/sysdep.h: Undef JUMPTARGET before use.
> * sysdeps/unix/sysv/linux/hppa/sysdep.h:
> Define __NR_semtimedop for compat with old kernels,
> PSEUDO_ERRVAL, SYSCALL_ERROR_LABEL under all conditions,
> INTERNAL_SYSCALL_DECL, INTERNAL_SYSCALL_ERROR_P,
> INTERNAL_SYSCALL_ERRNO, INTERNAL_SYSCALL, and undef
> JUMPTARGET before use.
> [PIC]: Save pic register around syscall.
> * sysdeps/unix/sysv/linux/hppa/sysdep.c (syscall):
> Cleanup asm statment.
I've applied this patch, but only because I really don't care how the PA
port looks.
The semtimedop definition is completely wrong. If you want all
syscall,s use appropriate headers.
You've modified the patch by hand and broke it, forcing me to do clean up.
The coding style is completely wrong and a terrible mess. The coding
standard document is available, read it.
The preprocessor directive indentation is wrong or non-existing.
- --
- --------------. ,-. 444 Castro Street
Ulrich Drepper \ ,-----------------' \ Mountain View, CA 94041 USA
Red Hat `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE/jN/W2ijCOnn/RHQRAjrzAJsEI3ukb5MQ/T0Wl0ihUX1l2ejBJACeL8GW
7tzXLthx8pW4Rhb+26NQkH4=
=8Fy5
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2003-10-15 5:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-12 21:32 [parisc-linux] [PATCH] Sysdeps changes for hppa Carlos O'Donell
2003-10-15 5:49 ` Ulrich Drepper [this message]
2003-10-15 14:35 ` [parisc-linux] " Carlos O'Donell
2003-10-15 14:35 ` Carlos O'Donell
2003-10-18 20:47 ` Carlos O'Donell
2003-10-18 20:47 ` Carlos O'Donell
2003-10-15 5:49 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F8CDFD6.1010300@redhat.com \
--to=drepper@redhat.com \
--cc=carlos@baldric.uwo.ca \
--cc=libc-alpha@sources.redhat.com \
--cc=parisc-linux@lists.parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.