Re: Badness in as_completed_request

[Nick Piggin <piggin@cyberone.com.au>]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

   

Aaron Lehmann wrote:

>I've been seeing this about every day for the past month or so, while
>tracking 2.6.0-test*. Usually by the time I feel like reporting it I'm
>a few revisions behind and decide to upgrade before complaining about
>it. Now I'm running -test9 and it still happens. This happens every
>few day or so under normal load and every few minutes under high I/O
>load. I'm running an x86 system with a 3ware RAID5:
>
>Badness in as_completed_request at drivers/block/as-iosched.c:919
>

This warning is harmless. Here is a patch against 2.6.0-test9-mm2.
Please test that kernel as it has a few other important as-iosched
fixes. Thanks.


[-- Attachment #2: as-warn-fix.patch --]
[-- Type: text/plain, Size: 591 bytes --]

 linux-2.6-npiggin/drivers/block/as-iosched.c |    2 --
 1 files changed, 2 deletions(-)

diff -puN drivers/block/as-iosched.c~as-warn-fix drivers/block/as-iosched.c
--- linux-2.6/drivers/block/as-iosched.c~as-warn-fix	2003-11-05 20:16:42.000000000 +1100
+++ linux-2.6-npiggin/drivers/block/as-iosched.c	2003-11-05 20:16:58.000000000 +1100
@@ -965,8 +965,6 @@ static void as_completed_request(request
 		return;
 
 	if (ad->changed_batch && ad->nr_dispatched == 1) {
-		WARN_ON(ad->batch_data_dir == arq->is_sync);
-
 		kblockd_schedule_work(&ad->antic_work);
 		ad->changed_batch = 0;
 

_