From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>,
"Mike_Phillips@URSCorp.com" <Mike_Phillips@URSCorp.com>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] ibmtr -- convert to new probeing
Date: Fri, 14 Nov 2003 20:07:33 -0500 [thread overview]
Message-ID: <3FB57C55.5090602@pobox.com> (raw)
In-Reply-To: <20031113112440.2fe0e12c.shemminger@osdl.org>
Stephen Hemminger wrote:
> This patch applies against net-drivers-2.5-exp. The line number offsets assume
> the earlier patchset, but this change doesn't overlap all those ether changes.
>
> * convert ibmtr driver to using the new probe interface -- ibmtr_probe2
> * keep old ibmtr_probe for use as init handle because ibmtr_cs uses it
> * cleanup error paths in ibmtr_probe1 and module init
> * make only used locally functions static
> * do request_region before doing i/o
> * irq and mem were not really settable as module parameters so removed
Given that there has been some other activity in this driver, I would
prefer to wait for Mike's ACK, before applying to net-drivers-2.5-exp
(and eventually 2.6 when it re-opens).
Jeff
next prev parent reply other threads:[~2003-11-15 1:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-13 19:24 [PATCH] ibmtr -- convert to new probeing Stephen Hemminger
2003-11-15 1:07 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-11-15 4:50 Mike_Phillips
2003-11-15 5:53 Mike_Phillips
2003-11-18 0:47 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FB57C55.5090602@pobox.com \
--to=jgarzik@pobox.com \
--cc=Mike_Phillips@URSCorp.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.