All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Xose Vazquez Perez <xose@wanadoo.es>, netdev@oss.sgi.com
Subject: Re: [PATCH ] more RTL-8139 clone boards
Date: Wed, 19 Nov 2003 12:37:34 -0500	[thread overview]
Message-ID: <3FBBAA5E.5020007@pobox.com> (raw)
In-Reply-To: <20031119092751.3407c944.shemminger@osdl.org>

Stephen Hemminger wrote:
> On Tue, 18 Nov 2003 20:46:34 +0100
> Xose Vazquez Perez <xose@wanadoo.es> wrote:
> 
> 
>>0x018A 0x0106 LevelOne FPC-0106TX
>>0x126C 0x1211 Nortel Networks 10/100BaseTX
>>0x1743 0x8139 Peppercon AG ROL-F
>>0x021B 0x8139 Compaq HNE-300
> 
> 
> Maybe time to  start using pci_ids.h?


This is mainly a matter of opinion.  My opinion:  no.  ;-)

I think it's rather silly to keep adding to pci_ids.h, when the ids are 
just arbitrary hex numbers with no useful value.  I certainly support 
mnemonic constants when they have value... but if the _only_ place a PCI 
id constant exists is (a) in a pci_device_id list and (b) in pci_ids.h, 
then it seems rather wasteful rather than helpful.

IMO, the constants just bloat the pci_device_id list, whereas the ones 
with hex numbers are nice, single lines.

As an aside, include/linux/pci_ids.h is a heavily patched file, and 
conflicts occur all the time.

	Jeff

  reply	other threads:[~2003-11-19 17:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-18 19:46 [PATCH ] more RTL-8139 clone boards Xose Vazquez Perez
2003-11-19 17:14 ` Jeff Garzik
2003-11-19 17:27 ` Stephen Hemminger
2003-11-19 17:37   ` Jeff Garzik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-02-22 15:26 Xose Vazquez Perez
2004-02-26  5:48 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FBBAA5E.5020007@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    --cc=xose@wanadoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.