From: Manfred Spraul <manfred@colorfullife.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>, Raj <raju@mailandnews.com>,
linux-kernel@vger.kernel.org, lhcs-devel@lists.sourceforge.net
Subject: Re: kernel BUG at kernel/exit.c:792!
Date: Wed, 03 Dec 2003 21:19:09 +0100 [thread overview]
Message-ID: <3FCE453D.9080701@colorfullife.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0312031203430.7406@home.osdl.org>
Linus Torvalds wrote:
>So as far as I can tell, the patch from Ingo and Srivatsa just paper over
>the _real_ bug. And the real fix is to get rid of the debugging helper
>completely, since it no longer serves any purpose, and it is WRONG!
>
>So tell me why it isn't wrong?
>
>
It's wrong, because next_thread() relies on
task->pids[PIDTYPE_TGID].pid_chain.next
That pointer is not valid after detach_pid(task, PIDTYPE_TGID), and
that's called within __unhash_process. Thus next_thread() fails if it's
called on a dead task. Srivatsa's second patch is the right change: If
pid_alive() is wrong, then break from the loop without calling
next_thread().
--
Manfred
next prev parent reply other threads:[~2003-12-03 20:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-03 10:08 kernel BUG at kernel/exit.c:792! Srivatsa Vaddagiri
[not found] ` <3FCDCEA3.1020209@mailandnews.com>
2003-12-03 12:53 ` Srivatsa Vaddagiri
2003-12-03 17:46 ` Manfred Spraul
2003-12-03 17:52 ` Manfred Spraul
2003-12-03 18:19 ` Linus Torvalds
2003-12-03 19:58 ` Ingo Molnar
2003-12-03 19:59 ` Ingo Molnar
2003-12-03 20:08 ` Linus Torvalds
2003-12-03 20:18 ` Ingo Molnar
2003-12-03 20:19 ` Manfred Spraul [this message]
2003-12-03 20:26 ` Ingo Molnar
2003-12-03 20:31 ` Ingo Molnar
2003-12-03 20:55 ` Linus Torvalds
2003-12-03 20:35 ` Ingo Molnar
2003-12-03 15:51 ` Linus Torvalds
2003-12-03 20:03 ` Ingo Molnar
2003-12-03 20:09 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FCE453D.9080701@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=lhcs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=raju@mailandnews.com \
--cc=torvalds@osdl.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.