From: Jeff Garzik <jgarzik@pobox.com>
To: Rask Ingemann Lambertsen <rask@sygehus.dk>
Cc: netdev@oss.sgi.com
Subject: Re: [RFR] new e100 driver
Date: Fri, 05 Dec 2003 13:01:19 -0500 [thread overview]
Message-ID: <3FD0C7EF.40305@pobox.com> (raw)
In-Reply-To: <20031205164347.B1291@sygehus.dk>
Rask Ingemann Lambertsen wrote:
> On Fri, Dec 05, 2003 at 01:38:43AM -0500, Jeff Garzik wrote:
>
>>e100 3.0.9_dev just got checked into net-drivers-2.5-exp queue. As I do
>>occasionally (especially for smaller drivers), I post them for review
>>and comment.
>
>
> How would I build it? A patch for the Makefile is missing.
Download the net-drivers-2.5-exp patch I am about to post :)
>>Patches welcome in addition to comments.
>>
>>One thing I am tempted to request is use of the new module_param()...
>
>
> Does anybody have a macro that turns module_parm() into MODULE_PARM() for
> 2.4 compatibility?
Due to semantics of MODULE_PARM(), that's impossible AFAIK.
>> * References:
>> * Intel 8255x 10/100 Mbps Ethernet Controller Family,
>> * Open Source Software Developers Manual,
>> * http://sourceforge.net/projects/e1000
>
> [cut]
>
>> * Hardware padding of short packets to minimum packet size is
>> * enabled. 82557 pads with 7Eh, while the later controllers pad
>> * with 00h.
>
>
> I would be nice if the documentation said so. A few days ago I spent half an
> hour or so trying to figure out why frames sent by an 82558 were padded with
> 0x00 rather than the documented 0x7e (with no sign of skb_padto(), memset()
> or anything similiar in the driver).
Do you mean the PDF documentation? I dunno how much control Scott
Feldman and his team have over that.
Jeff
next prev parent reply other threads:[~2003-12-05 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-05 6:38 [RFR] new e100 driver Jeff Garzik
2003-12-05 15:43 ` Rask Ingemann Lambertsen
2003-12-05 18:01 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-12-05 22:01 Feldman, Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FD0C7EF.40305@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=rask@sygehus.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.