From: Andreas Beckmann <andreas@abeckmann.de>
To: linux-kernel@vger.kernel.org
Cc: ralf@linux-mips.org
Subject: [PATCH] inclusion of <asm/system.h> into spinlock.h breaks sparc
Date: Sat, 06 Dec 2003 23:56:04 +0100 [thread overview]
Message-ID: <3FD25E84.5050702@abeckmann.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]
Hi,
the recent inclusion of <asm/system.h> into spinlock.h causes a cyclic
inclusion under the sparc architecture. This breaks the build (at the
beginning of make dep) in oplib.h because spinlock_t is not yet defined.
linux/spinlock.h
asm/system.h
asm/oplib.h
linux/spinlock.h
ERROR! (asm/oplib.h)
I was working with 2.4.23-bk3 and -bk4.
The change was introduced in the following changeset:
--------------------
ChangeSet 1.1192.4.2 2003/12/02 11:25:25 ralf@linux-mips.org
[PATCH] Include <asm/system.h> into spinlock.h
<linux/spinlock.h> uses local_irq_save() etc. from <asm/spinlock.h> but
relies on this header file having been dragged in on some other way.
So if things are just right the build may blow up ...
include/linux/spinlock.h 1.9 2003/11/28 10:38:30 ralf@linux-mips.org
Include <asm/system.h> into spinlock.h
--------------------
Not including asm/oplib.h from asm/system.h seems to fix this.
The patch drops this include.
Andreas
Please CC: me in your replies.
[-- Attachment #2: asm_system_h.diff --]
[-- Type: text/plain, Size: 324 bytes --]
--- linux-2.4.23/include/asm-sparc/system.h.orig 2003-11-28 19:26:21.000000000 +0100
+++ linux-2.4.23/include/asm-sparc/system.h 2003-12-06 05:49:05.000000000 +0100
@@ -10,7 +10,6 @@
#ifdef __KERNEL__
#include <asm/page.h>
-#include <asm/oplib.h>
#include <asm/psr.h>
#include <asm/ptrace.h>
#include <asm/btfixup.h>
reply other threads:[~2003-12-06 22:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FD25E84.5050702@abeckmann.de \
--to=andreas@abeckmann.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.