From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Menage Subject: Re: ACPI global lock macros Date: Tue, 09 Dec 2003 11:04:05 -0800 Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <3FD61CA5.6050203@google.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: "Grover, Andrew" Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-acpi@vger.kernel.org Grover, Andrew wrote: > > BTW, i386, x86_64 and ia64 all have this macro, so these all might need > to be looked at. > Yes, it was the differences between the i386 and x86_64 versions that made me notice this problem. The ia64 version is in C, so looks safer. Ideally there would be a common C definition - the only arch-specific part should be the locked cmpxchg, unless this lock is likely to be taken/released so often that it's performance critical. Paul ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266082AbTLIStI (ORCPT ); Tue, 9 Dec 2003 13:49:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266084AbTLIStI (ORCPT ); Tue, 9 Dec 2003 13:49:08 -0500 Received: from 216-239-45-4.google.com ([216.239.45.4]:17935 "EHLO 216-239-45-4.google.com") by vger.kernel.org with ESMTP id S266082AbTLIStF (ORCPT ); Tue, 9 Dec 2003 13:49:05 -0500 Message-ID: <3FD61CA5.6050203@google.com> Date: Tue, 09 Dec 2003 11:04:05 -0800 From: Paul Menage User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030718 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Grover, Andrew" CC: linux-kernel@vger.kernel.org, acpi-devel@lists.sourceforge.net Subject: Re: [ACPI] ACPI global lock macros References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Grover, Andrew wrote: > > BTW, i386, x86_64 and ia64 all have this macro, so these all might need > to be looked at. > Yes, it was the differences between the i386 and x86_64 versions that made me notice this problem. The ia64 version is in C, so looks safer. Ideally there would be a common C definition - the only arch-specific part should be the locked cmpxchg, unless this lock is likely to be taken/released so often that it's performance critical. Paul