From: Manfred Spraul <manfred@colorfullife.com>
To: "Feldman, Scott" <scott.feldman@intel.com>
Cc: Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2003@gmx.net>,
netdev@oss.sgi.com
Subject: Re: forcedeth: version 0.20 available
Date: Tue, 23 Dec 2003 10:19:21 +0100 [thread overview]
Message-ID: <3FE80899.40400@colorfullife.com> (raw)
In-Reply-To: <C6F5CF431189FA4CBAEC9E7DD5441E0102CBDD7D@orsmsx402.jf.intel.com>
Feldman, Scott wrote:
>>version 0.20 of forcedeth (GPLed nvnet replacement for nForce
>>on-board nics) for Linux 2.4 and 2.6 is available at
>>http://www.hailfinger.org/carldani/linux/patch> es/forcedeth/
>>
>>
>
>Carl-Daniel, I'm bored:
>
>* Consider prefixing function names unique prefix so driver is
> not anonymous in backtraces.
>* remove_nic: use free_netdev rather than kfree.
>
Ups. My fault.
>* remove_nic: should check if(dev) before dereferencing?
>* remove_nic: check np->rx_ring before pci_free_consistent?
>
I think it cannot be NULL, but I'll double check it.
>* NAPI support would be nice instead of the do_nic_poll timer.
>
We are still guessing the meaning of some irq flags. Until we understand
them, it's IMHO too dangerous to rely on masking the rx interrupts for
rx processing. Additionally I"m not a big fan of NAPI.
ethtool is on my TODO list, but I don't know when I'll have the time to
implement it.
--
Manfred
next prev parent reply other threads:[~2003-12-23 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-23 3:25 forcedeth: version 0.20 available Feldman, Scott
2003-12-23 9:19 ` Manfred Spraul [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-12-23 0:43 Carl-Daniel Hailfinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FE80899.40400@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=c-d.hailfinger.kernel.2003@gmx.net \
--cc=netdev@oss.sgi.com \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.