Jens Axboe wrote: > It looks better, getting there! Thx! [block_dump code in set_buffer_dirty()] > Probably want to move this to the actual set_page_dirty() function(s). Done. Works better, seeing a bit more output as well. [block_dump code in submit_bh()] > You don't want this in submit_bh(), that hardly matters at all anymore. > It wants to be in submit_bio(). And you should follow the brace > placement style. And just dump device+offset, b_count is not > interesting. Done. This gives some extra output as well, which is good. > The rest looks ok, apart from style. I've changed it to use the correct bracing style. Is it OK now? Thanks for the feedback. Do you see any more problems with the current patch, or is it OK like this? Bart