From: Hans Reiser <reiser@namesys.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Jesper Juhl <juhl-lkml@dif.dk>,
linux-kernel@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>
Subject: Re: [PATCH] fs/fcntl.c - remove impossible <0 check in do_fcntl - arg is unsigned.
Date: Thu, 08 Jan 2004 14:10:31 +0300 [thread overview]
Message-ID: <3FFD3AA7.7000007@namesys.com> (raw)
In-Reply-To: <Pine.LNX.4.56.0401081034200.10083@jju_lnx.backbone.dif.dk>
Code is like poetry --- bloat needs to come out of it, and a rigorous
discipline of removing all unnecessary complexity from it needs to be
made a habit so that the exact meaning of it will be seen by all.
Boy was that pompous.;-) Oh well, I'd like the reiserfs portions of his
patch to be accepted, and I'll forward them to you in a few days.
Please consider accepting them.
Hans
Jesper Juhl wrote:
>On Wed, 7 Jan 2004, Linus Torvalds wrote:
>
>
>
>> The fact that the compiler can optimize
>>away one of the tests if the type is right i2Ds fine. It seems to be
>>draconian to remove code that is correct and safe, especially when the
>>code has no real downsides to it.
>>
>>
--
Hans
next prev parent reply other threads:[~2004-01-08 11:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-08 1:44 [PATCH] fs/fcntl.c - remove impossible <0 check in do_fcntl - arg is unsigned Jesper Juhl
2004-01-08 2:47 ` Linus Torvalds
2004-01-08 10:27 ` Jesper Juhl
2004-01-08 11:07 ` Paul Jackson
2004-01-08 11:10 ` Hans Reiser [this message]
2004-01-08 12:13 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FFD3AA7.7000007@namesys.com \
--to=reiser@namesys.com \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.