From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=UIVQdBfPaD1o1EXblvXBQsMBcOSOdxtd8qEfUxpHWG0=; b=qD6XitCvL+eBnQaTOZJQktDepqBgJzQn08GpHrMS1gzNM/dczhOXFx2RG+7Y5dhlQ8Pb Mz3yReWI/NhCGJyKTRLik3Urt6duM/xISWyBHOG+Ndo8KDQRKx8Xgh0cgGlerh0UfRiN 5hKSEMuaQ4Q0kgiBuEPStRPH/LTbC5BNeCB6UQkULn4YxrxSBxXvCvYkD0l1wX6uTOg6 lRFSW/E+q+GL2KlKb5AkwZmklu15OdYwqu+9idJV4Urdbg3VONytJZmnjUCCUXJ/m6jm G0iprFFlWvKcc2ZRQtlfPQmvMNgm90dwivKv28VCEI5ppRDGlB80PgnUKB7dhxsFFvws uA== Message-ID: <3a002a6a-9135-ad45-3fed-7dd270450d0b@linux.ibm.com> Date: Fri, 14 Oct 2022 09:30:24 +0200 MIME-Version: 1.0 References: <20221010172813.204597-1-mst@redhat.com> <20221010172813.204597-8-mst@redhat.com> From: Christian Borntraeger In-Reply-To: <20221010172813.204597-8-mst@redhat.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: [Virtio-fs] Regression save/restore of vsock: (was [PULL 07/55] hw/virtio: move vm_running check to virtio_device_started) List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= , "Dr. David Alan Gilbert" , Stefan Hajnoczi , Mathieu Poirier , virtio-fs@redhat.com Am 10.10.22 um 19:29 schrieb Michael S. Tsirkin: > From: Alex Benn=C3=A9e >=20 > All the boilerplate virtio code does the same thing (or should at > least) of checking to see if the VM is running before attempting to > start VirtIO. Push the logic up to the common function to avoid > getting a copy and paste wrong. >=20 > Signed-off-by: Alex Benn=C3=A9e > Message-Id: <20220802095010.3330793-11-alex.bennee@linaro.org> > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin This results in a regression for our s390x CI when doing save/restore of gu= ests with vsock: #1 0x000003ff9a248580 raise (libc.so.6 + 0x48580) #2 0x000003ff9a22b5c0 abort (libc.so.6 + 0x2b5c0) #3 0x000003ff9a2409da __assert_fail_base (libc.so.6 + 0x4= 09da) #4 0x000003ff9a240a4e __assert_fail (libc.so.6 + 0x40a4e) #5 0x000002aa2d69a066 vhost_vsock_common_pre_save (qemu-s= ystem-s390x + 0x39a066) #6 0x000002aa2d55570e vmstate_save_state_v (qemu-system-s= 390x + 0x25570e) #7 0x000002aa2d556218 vmstate_save_state (qemu-system-s39= 0x + 0x256218) #8 0x000002aa2d570ba4 qemu_savevm_state_complete_precopy_= non_iterable (qemu-system-s390x + 0x270ba4) #9 0x000002aa2d5710b6 qemu_savevm_state_complete_precopy = (qemu-system-s390x + 0x2710b6) #10 0x000002aa2d564d0e migration_completion (qemu-system-s= 390x + 0x264d0e) #11 0x000002aa2d8db25c qemu_thread_start (qemu-system-s390= x + 0x5db25c) #12 0x000003ff9a296248 start_thread (libc.so.6 + 0x96248) #13 0x000003ff9a31183e thread_start (libc.so.6 + 0x11183e) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3695C433FE for ; Fri, 14 Oct 2022 07:34:45 +0000 (UTC) Received: from localhost ([::1]:48398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojFDQ-00006w-Gt for qemu-devel@archiver.kernel.org; Fri, 14 Oct 2022 03:34:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojF9U-0006PR-Hh for qemu-devel@nongnu.org; Fri, 14 Oct 2022 03:30:42 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33204) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojF9R-0006AA-KZ for qemu-devel@nongnu.org; Fri, 14 Oct 2022 03:30:39 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29E6wlmS017171; Fri, 14 Oct 2022 07:30:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=UIVQdBfPaD1o1EXblvXBQsMBcOSOdxtd8qEfUxpHWG0=; b=qD6XitCvL+eBnQaTOZJQktDepqBgJzQn08GpHrMS1gzNM/dczhOXFx2RG+7Y5dhlQ8Pb Mz3yReWI/NhCGJyKTRLik3Urt6duM/xISWyBHOG+Ndo8KDQRKx8Xgh0cgGlerh0UfRiN 5hKSEMuaQ4Q0kgiBuEPStRPH/LTbC5BNeCB6UQkULn4YxrxSBxXvCvYkD0l1wX6uTOg6 lRFSW/E+q+GL2KlKb5AkwZmklu15OdYwqu+9idJV4Urdbg3VONytJZmnjUCCUXJ/m6jm G0iprFFlWvKcc2ZRQtlfPQmvMNgm90dwivKv28VCEI5ppRDGlB80PgnUKB7dhxsFFvws uA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3k6dc9gbcq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Oct 2022 07:30:30 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 29E7DgX4025546; Fri, 14 Oct 2022 07:30:30 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3k6dc9gbbj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Oct 2022 07:30:29 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 29E7L42M028151; Fri, 14 Oct 2022 07:30:27 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma04ams.nl.ibm.com with ESMTP id 3k30u9gscm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Oct 2022 07:30:27 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 29E7UPP93998244 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Oct 2022 07:30:25 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B9195204E; Fri, 14 Oct 2022 07:30:25 +0000 (GMT) Received: from [9.171.35.51] (unknown [9.171.35.51]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id B9E0752059; Fri, 14 Oct 2022 07:30:24 +0000 (GMT) Message-ID: <3a002a6a-9135-ad45-3fed-7dd270450d0b@linux.ibm.com> Date: Fri, 14 Oct 2022 09:30:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Regression save/restore of vsock: (was [PULL 07/55] hw/virtio: move vm_running check to virtio_device_started) To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= , "Dr. David Alan Gilbert" , Stefan Hajnoczi , Mathieu Poirier , virtio-fs@redhat.com References: <20221010172813.204597-1-mst@redhat.com> <20221010172813.204597-8-mst@redhat.com> Content-Language: en-US From: Christian Borntraeger In-Reply-To: <20221010172813.204597-8-mst@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: TF4TZ78tL5NaBj6w5f48XYhD3DFbw4jj X-Proofpoint-ORIG-GUID: LMzrfEdw8QVgHH4A1d0IvRK8MQ35jzrM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-14_02,2022-10-13_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1011 priorityscore=1501 impostorscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210140041 Received-SPF: pass client-ip=148.163.156.1; envelope-from=borntraeger@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 10.10.22 um 19:29 schrieb Michael S. Tsirkin: > From: Alex Bennée > > All the boilerplate virtio code does the same thing (or should at > least) of checking to see if the VM is running before attempting to > start VirtIO. Push the logic up to the common function to avoid > getting a copy and paste wrong. > > Signed-off-by: Alex Bennée > Message-Id: <20220802095010.3330793-11-alex.bennee@linaro.org> > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin This results in a regression for our s390x CI when doing save/restore of guests with vsock: #1 0x000003ff9a248580 raise (libc.so.6 + 0x48580) #2 0x000003ff9a22b5c0 abort (libc.so.6 + 0x2b5c0) #3 0x000003ff9a2409da __assert_fail_base (libc.so.6 + 0x409da) #4 0x000003ff9a240a4e __assert_fail (libc.so.6 + 0x40a4e) #5 0x000002aa2d69a066 vhost_vsock_common_pre_save (qemu-system-s390x + 0x39a066) #6 0x000002aa2d55570e vmstate_save_state_v (qemu-system-s390x + 0x25570e) #7 0x000002aa2d556218 vmstate_save_state (qemu-system-s390x + 0x256218) #8 0x000002aa2d570ba4 qemu_savevm_state_complete_precopy_non_iterable (qemu-system-s390x + 0x270ba4) #9 0x000002aa2d5710b6 qemu_savevm_state_complete_precopy (qemu-system-s390x + 0x2710b6) #10 0x000002aa2d564d0e migration_completion (qemu-system-s390x + 0x264d0e) #11 0x000002aa2d8db25c qemu_thread_start (qemu-system-s390x + 0x5db25c) #12 0x000003ff9a296248 start_thread (libc.so.6 + 0x96248) #13 0x000003ff9a31183e thread_start (libc.so.6 + 0x11183e)