From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=yong.b.li@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43W6RZ1lWtzDqGl for ; Fri, 4 Jan 2019 12:20:41 +1100 (AEDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2019 17:20:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,437,1539673200"; d="scan'208";a="131393207" Received: from linux.intel.com ([10.54.29.200]) by fmsmga002.fm.intel.com with ESMTP; 03 Jan 2019 17:20:38 -0800 Received: from [10.239.197.33] (yongli3-mobl.ccr.corp.intel.com [10.239.197.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 5E7DC58028E; Thu, 3 Jan 2019 17:20:37 -0800 (PST) Subject: Re: journal log messages are missing with latest version To: Patrick Venture , Matt Spinler , William Kennington Cc: OpenBMC Maillist References: <000601d498c5$7c4c2010$74e46030$@linux.intel.com> From: "Li, Yong B" Message-ID: <3a1d3ae9-e067-c166-96cd-b91f984de3d5@linux.intel.com> Date: Fri, 4 Jan 2019 09:20:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 01:20:43 -0000 Thanks Patrick for your mails. Will test https://gerrit.openbmc-project.xyz/17054, and update the results. On 1/4/2019 6:33 AM, Patrick Venture wrote: > On Thu, Jan 3, 2019 at 2:28 PM Patrick Venture wrote: >> On Thu, Jan 3, 2019 at 11:19 AM Patrick Venture wrote: >>> On Thu, Jan 3, 2019 at 10:07 AM Matt Spinler >>> wrote: >>>> On 2019-01-02 13:09, Patrick Venture wrote: >>>>> On Thu, Dec 20, 2018 at 4:38 PM Yong Li >>>>> wrote: >>>>>> >>>>>> >>>>>> Hi Patrick, >>>>>> >>>>>> >>>>>> >>>>>> I encountered a problem after upgrade to the latest opnebmc version: >>>>>> >>>>>> >>>>>> >>>>>> These log messages in ipmid are missing with the “journalctl -f”. >>>>> Which log messages? >>>> >>>> This showed up on all of our systems too, anything logged using >>>> phosphor-logging >>>> is missing from the journal. I even ended up using a git bisect to also >>>> narrow >>>> it down to: >>>> >>>> phosphor-logging: srcrev bump 30047bf964..31552c05e2 >>>> >>>> Patrick Venture (5): >>>> add sdjournal interface to inject tests >>>> test: use only one main library >>>> bugfix: add fixes to mock class >>>> bugfix: rename method to match implementation >>>> test: add test to force building of sdjournal mock >>>> >>> William, you've been digging into sdbus a lot recently, can you take a >>> deep look at the patchset above and see what I may have messed up? >>> The phosphor-logging unit-tests were broken until I got it "working." >>> Which lead me to believe that it's not correct -- and the daemons that >>> have unit-tests that hit the log message are seeing the calls. >> From reading more into the var_args pass-through, that may be the >> issue. One cannot pass the var args down directly like this. I >> propose to initially snip out this extra call and then revisit so that >> it'll resume working. > https://gerrit.openbmc-project.xyz/17054 >> The problem is that sd_journal_send doesn't expect a va_list argument, >> but rather strictly var args, which aren't the same. >> >>>>>> >>>>>> >>>>>> My tests shows that the blow change is related, after I revert it, I >>>>>> can get these log messages. >>>>>> >>>>>> >>>>>> >>>>>> Did you meet such issue, or any suggestions/comments to narrow down >>>>>> this issue? >>>>>> >>>>>> https://github.com/openbmc/phosphor-logging/commit/59a6b1f27e83066baa6f3711c88d6a3b9a5c4d49 >>>>>> >>>>>> add sdjournal interface to inject tests >>>>> There were some follow-on patches for phosphor-logging that you >>>>> shouldn't need -- it's >>>>> >>>>> What SHA is for your https://github.com/openbmc/phosphor-host-ipmid ? >>>>> (so I know what version of that is in use by you). >>>>> >>>>> Checking the HEAD version of >>>>> https://github.com/openbmc/phosphor-host-ipmid/blob/master/Makefile.am, >>>>> I see it's including the proper libs to get the full phosphor-logging >>>>> objects. >>>>> >>>>>> >>>>>> >>>>>> Thanks, >>>>>> >>>>>> Yong