From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Jianan Huang <jnhuang95@gmail.com>,
linux-f2fs-devel@lists.sourceforge.net, jaegeuk@kernel.org
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: quota: fix stale lock holder on remount failure
Date: Wed, 9 Sep 2026 20:07:50 +0800 [thread overview]
Message-ID: <3a22ec95-18a6-4f92-8bc2-80f13bc7de32@kernel.org> (raw)
In-Reply-To: <20260909114615.1390443-1-jnhuang95@gmail.com>
On 9/9/26 19:46, Jianan Huang wrote:
> F2FS remount can fail while duplicating a journalled quota file name.
>
> f2fs_remount()
> - sbi->umount_lock_holder = current
> - kstrdup(F2FS_OPTION(sbi).s_qf_names[i])
> : fails
> - free previously duplicated names
> - return -ENOMEM
>
> The direct return leaves umount_lock_holder pointing at the failed
> remount context. A later checkpoint may then wrongly treat another
> context as the s_umount lock holder.
>
> Add a restore_holder cleanup path and use it before returning -ENOMEM.
>
> Fixes: eb85c2410d6f ("f2fs: quota: fix to avoid warning in dquot_writeback_dquots()")
> Signed-off-by: Jianan Huang <jnhuang95@gmail.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-09-09 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 11:46 [f2fs-dev] [PATCH v2] f2fs: quota: fix stale lock holder on remount failure Jianan Huang
2026-09-09 12:07 ` Chao Yu via Linux-f2fs-devel [this message]
2026-09-14 15:30 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a22ec95-18a6-4f92-8bc2-80f13bc7de32@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=jnhuang95@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.