From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jammy Huang Date: Wed, 3 Nov 2021 13:02:38 +0800 Subject: [PATCH v2] media: aspeed: fix mode-detect always time out at 2nd run In-Reply-To: References: <20211103011357.22067-1-jammy_huang@aspeedtech.com> Message-ID: <3a40bb81-2c6e-47e3-fb85-e615aecd129a@aspeedtech.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Dear Joel, Sure. Thanks for your reminder. On 2021/11/3 ?? 09:53, Joel Stanley wrote: > On Wed, 3 Nov 2021 at 01:47, Joel Stanley wrote: >> On Wed, 3 Nov 2021 at 01:13, Jammy Huang wrote: >>> aspeed_video_get_resolution() will try to do res-detect again if the >>> timing got in last try is invalid. But it will always time out because >>> VE_SEQ_CTRL_TRIG_MODE_DET is only cleared after 1st mode-detect. >>> >>> To fix the problem, just clear VE_SEQ_CTRL_TRIG_MODE_DET before setting >>> it in aspeed_video_enable_mode_detect(). >>> >>> Signed-off-by: Jammy Huang >>> Acked-by: Paul Menzel >> Reviewed-by: Joel Stanley > When applying, can we please have this tag added: > > Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver") > > Cheers, > > Joel > > >>> --- >>> v2: >>> - update commit message >>> --- >>> drivers/media/platform/aspeed-video.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >>> index 5ffbabf884eb..fea5e4d0927e 100644 >>> --- a/drivers/media/platform/aspeed-video.c >>> +++ b/drivers/media/platform/aspeed-video.c >>> @@ -518,6 +518,10 @@ static void aspeed_video_enable_mode_detect(struct aspeed_video *video) >>> aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, >>> VE_INTERRUPT_MODE_DETECT); >>> >>> + /* Disable mode detect in order to re-trigger */ >>> + aspeed_video_update(video, VE_SEQ_CTRL, >>> + VE_SEQ_CTRL_TRIG_MODE_DET, 0); >>> + >>> /* Trigger mode detect */ >>> aspeed_video_update(video, VE_SEQ_CTRL, 0, VE_SEQ_CTRL_TRIG_MODE_DET); >>> } >>> @@ -809,10 +813,6 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) >>> return; >>> } >>> >>> - /* Disable mode detect in order to re-trigger */ >>> - aspeed_video_update(video, VE_SEQ_CTRL, >>> - VE_SEQ_CTRL_TRIG_MODE_DET, 0); >>> - >>> aspeed_video_check_and_set_polarity(video); >>> >>> aspeed_video_enable_mode_detect(video); >>> -- >>> 2.25.1 >>> -- Best Regards Jammy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B423C433EF for ; Wed, 3 Nov 2021 05:04:19 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 940606109F for ; Wed, 3 Nov 2021 05:04:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 940606109F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HkZSJ5st1z2yPN for ; Wed, 3 Nov 2021 16:04:16 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=aspeedtech.com (client-ip=211.20.114.71; helo=twspam01.aspeedtech.com; envelope-from=jammy_huang@aspeedtech.com; receiver=) Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HkZRn4Q6Mz2xBq; Wed, 3 Nov 2021 16:03:46 +1100 (AEDT) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1A34dkWW071525; Wed, 3 Nov 2021 12:39:46 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Nov 2021 13:02:37 +0800 Message-ID: <3a40bb81-2c6e-47e3-fb85-e615aecd129a@aspeedtech.com> Date: Wed, 3 Nov 2021 13:02:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v2] media: aspeed: fix mode-detect always time out at 2nd run Content-Language: en-US To: Joel Stanley References: <20211103011357.22067-1-jammy_huang@aspeedtech.com> From: Jammy Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1A34dkWW071525 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Menzel , linux-aspeed , Andrew Jeffery , OpenBMC Maillist , Eddie James , Linux Kernel Mailing List , Mauro Carvalho Chehab , Linux ARM , "linux-media@vger.kernel.org" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Dear Joel, Sure. Thanks for your reminder. On 2021/11/3 上午 09:53, Joel Stanley wrote: > On Wed, 3 Nov 2021 at 01:47, Joel Stanley wrote: >> On Wed, 3 Nov 2021 at 01:13, Jammy Huang wrote: >>> aspeed_video_get_resolution() will try to do res-detect again if the >>> timing got in last try is invalid. But it will always time out because >>> VE_SEQ_CTRL_TRIG_MODE_DET is only cleared after 1st mode-detect. >>> >>> To fix the problem, just clear VE_SEQ_CTRL_TRIG_MODE_DET before setting >>> it in aspeed_video_enable_mode_detect(). >>> >>> Signed-off-by: Jammy Huang >>> Acked-by: Paul Menzel >> Reviewed-by: Joel Stanley > When applying, can we please have this tag added: > > Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver") > > Cheers, > > Joel > > >>> --- >>> v2: >>> - update commit message >>> --- >>> drivers/media/platform/aspeed-video.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >>> index 5ffbabf884eb..fea5e4d0927e 100644 >>> --- a/drivers/media/platform/aspeed-video.c >>> +++ b/drivers/media/platform/aspeed-video.c >>> @@ -518,6 +518,10 @@ static void aspeed_video_enable_mode_detect(struct aspeed_video *video) >>> aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, >>> VE_INTERRUPT_MODE_DETECT); >>> >>> + /* Disable mode detect in order to re-trigger */ >>> + aspeed_video_update(video, VE_SEQ_CTRL, >>> + VE_SEQ_CTRL_TRIG_MODE_DET, 0); >>> + >>> /* Trigger mode detect */ >>> aspeed_video_update(video, VE_SEQ_CTRL, 0, VE_SEQ_CTRL_TRIG_MODE_DET); >>> } >>> @@ -809,10 +813,6 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) >>> return; >>> } >>> >>> - /* Disable mode detect in order to re-trigger */ >>> - aspeed_video_update(video, VE_SEQ_CTRL, >>> - VE_SEQ_CTRL_TRIG_MODE_DET, 0); >>> - >>> aspeed_video_check_and_set_polarity(video); >>> >>> aspeed_video_enable_mode_detect(video); >>> -- >>> 2.25.1 >>> -- Best Regards Jammy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84485C433EF for ; Wed, 3 Nov 2021 21:08:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B9D160F39 for ; Wed, 3 Nov 2021 21:08:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4B9D160F39 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IQB7RNTlgVLYF+4qVf7KKwMCHE5bQSPDyhCVEpE+V54=; b=Ci0TAIIOwScmz/ VckPA3d2Z7NAgHukPsHYNmDKmh/+O79xlHnU6zYInChEva66c/akvP/077Rddn6kcln04mDDusu0d 1+dWEx7IRbzzPnTqCLQs39MivsEgufMrxzZzgZ6iodeco/LYIbt4pyzm6qBiDS3aFsAqiDef3WVkN nBxZgCA8yiSSFp5Kz26F3K0qVUsaiz1Jiv5xc6zTGBvCxGtcdtOvK9zk/KgGcTcnm6jTUD8Fi0VWW 15U2qSfrLJGdQ+aWv3rERAkI1e8YH2KQgvMtVo5Fuev582U1EWBS4Lpk1OSakSP8Fyv+DpeF4MCAi SryNUNKwKQFDjal/2q5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miNSj-006cka-AP; Wed, 03 Nov 2021 21:06:25 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1miNSV-006cgx-Ox for linux-arm-kernel@bombadil.infradead.org; Wed, 03 Nov 2021 21:06:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=V13v59zcuRHwjBb3RPjgoc+/iaDHCyMbc5/kok8oaW0=; b=T+J9n7Sv9YFSF0CjBPLNQ29a/j x10aoPEY8Cjb9ifQRQ+LZHqaKUDnR1QbOI9kM95tUlvgOfVExrTv22E+59CCmcAznb9xwxBSHVONf XkxYUaPwew01i4AESxVDGLRalVxkVaDdZVZEUC7xgXvE5n0/kULu+yt6B2oiueOGvcL75wTbGA2eZ 9zIj+9Ffq53mjcK8BO7x3dxnLSww55fGzPHrwuLA49yDhbcUlIQYrRrFhDbKtKumRf3KJoLYU9vvb BBa4z0Isp/EgxoZZ/tvxjUrkMMiVpknAhMgPiAz+pwFxYjccssIGi6ma9br4vWgP65dawyTP9O7ek 7oCmg7VQ==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mi8QY-00DtLj-Hk for linux-arm-kernel@lists.infradead.org; Wed, 03 Nov 2021 05:03:33 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1A34dkWW071525; Wed, 3 Nov 2021 12:39:46 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Nov 2021 13:02:37 +0800 Message-ID: <3a40bb81-2c6e-47e3-fb85-e615aecd129a@aspeedtech.com> Date: Wed, 3 Nov 2021 13:02:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v2] media: aspeed: fix mode-detect always time out at 2nd run Content-Language: en-US To: Joel Stanley CC: Eddie James , Mauro Carvalho Chehab , Andrew Jeffery , "linux-media@vger.kernel.org" , OpenBMC Maillist , Linux ARM , linux-aspeed , Linux Kernel Mailing List , Paul Menzel References: <20211103011357.22067-1-jammy_huang@aspeedtech.com> From: Jammy Huang In-Reply-To: X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1A34dkWW071525 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211103_050331_450349_D5877FE7 X-CRM114-Status: GOOD ( 11.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RGVhciBKb2VsLAoKU3VyZS4gVGhhbmtzIGZvciB5b3VyIHJlbWluZGVyLgoKT24gMjAyMS8xMS8z IOS4iuWNiCAwOTo1MywgSm9lbCBTdGFubGV5IHdyb3RlOgo+IE9uIFdlZCwgMyBOb3YgMjAyMSBh dCAwMTo0NywgSm9lbCBTdGFubGV5IDxqb2VsQGptcy5pZC5hdT4gd3JvdGU6Cj4+IE9uIFdlZCwg MyBOb3YgMjAyMSBhdCAwMToxMywgSmFtbXkgSHVhbmcgPGphbW15X2h1YW5nQGFzcGVlZHRlY2gu Y29tPiB3cm90ZToKPj4+IGFzcGVlZF92aWRlb19nZXRfcmVzb2x1dGlvbigpIHdpbGwgdHJ5IHRv IGRvIHJlcy1kZXRlY3QgYWdhaW4gaWYgdGhlCj4+PiB0aW1pbmcgZ290IGluIGxhc3QgdHJ5IGlz IGludmFsaWQuIEJ1dCBpdCB3aWxsIGFsd2F5cyB0aW1lIG91dCBiZWNhdXNlCj4+PiBWRV9TRVFf Q1RSTF9UUklHX01PREVfREVUIGlzIG9ubHkgY2xlYXJlZCBhZnRlciAxc3QgbW9kZS1kZXRlY3Qu Cj4+Pgo+Pj4gVG8gZml4IHRoZSBwcm9ibGVtLCBqdXN0IGNsZWFyIFZFX1NFUV9DVFJMX1RSSUdf TU9ERV9ERVQgYmVmb3JlIHNldHRpbmcKPj4+IGl0IGluIGFzcGVlZF92aWRlb19lbmFibGVfbW9k ZV9kZXRlY3QoKS4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBKYW1teSBIdWFuZyA8amFtbXlfaHVh bmdAYXNwZWVkdGVjaC5jb20+Cj4+PiBBY2tlZC1ieTogUGF1bCBNZW56ZWwgPHBtZW56ZWxAbW9s Z2VuLm1wZy5kZT4KPj4gUmV2aWV3ZWQtYnk6IEpvZWwgU3RhbmxleSA8am9lbEBqbXMuaWQuYXU+ Cj4gV2hlbiBhcHBseWluZywgY2FuIHdlIHBsZWFzZSBoYXZlIHRoaXMgdGFnIGFkZGVkOgo+Cj4g Rml4ZXM6IGQyYjQzODdmM2JkZiAoIm1lZGlhOiBwbGF0Zm9ybTogQWRkIEFzcGVlZCBWaWRlbyBF bmdpbmUgZHJpdmVyIikKPgo+IENoZWVycywKPgo+IEpvZWwKPgo+Cj4+PiAtLS0KPj4+IHYyOgo+ Pj4gICAgLSB1cGRhdGUgY29tbWl0IG1lc3NhZ2UKPj4+IC0tLQo+Pj4gICBkcml2ZXJzL21lZGlh L3BsYXRmb3JtL2FzcGVlZC12aWRlby5jIHwgOCArKysrLS0tLQo+Pj4gICAxIGZpbGUgY2hhbmdl ZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL21lZGlhL3BsYXRmb3JtL2FzcGVlZC12aWRlby5jIGIvZHJpdmVycy9tZWRpYS9wbGF0 Zm9ybS9hc3BlZWQtdmlkZW8uYwo+Pj4gaW5kZXggNWZmYmFiZjg4NGViLi5mZWE1ZTRkMDkyN2Ug MTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL2FzcGVlZC12aWRlby5jCj4+ PiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL2FzcGVlZC12aWRlby5jCj4+PiBAQCAtNTE4 LDYgKzUxOCwxMCBAQCBzdGF0aWMgdm9pZCBhc3BlZWRfdmlkZW9fZW5hYmxlX21vZGVfZGV0ZWN0 KHN0cnVjdCBhc3BlZWRfdmlkZW8gKnZpZGVvKQo+Pj4gICAgICAgICAgYXNwZWVkX3ZpZGVvX3Vw ZGF0ZSh2aWRlbywgVkVfSU5URVJSVVBUX0NUUkwsIDAsCj4+PiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFZFX0lOVEVSUlVQVF9NT0RFX0RFVEVDVCk7Cj4+Pgo+Pj4gKyAgICAgICAvKiBE aXNhYmxlIG1vZGUgZGV0ZWN0IGluIG9yZGVyIHRvIHJlLXRyaWdnZXIgKi8KPj4+ICsgICAgICAg YXNwZWVkX3ZpZGVvX3VwZGF0ZSh2aWRlbywgVkVfU0VRX0NUUkwsCj4+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgVkVfU0VRX0NUUkxfVFJJR19NT0RFX0RFVCwgMCk7Cj4+PiArCj4+PiAg ICAgICAgICAvKiBUcmlnZ2VyIG1vZGUgZGV0ZWN0ICovCj4+PiAgICAgICAgICBhc3BlZWRfdmlk ZW9fdXBkYXRlKHZpZGVvLCBWRV9TRVFfQ1RSTCwgMCwgVkVfU0VRX0NUUkxfVFJJR19NT0RFX0RF VCk7Cj4+PiAgIH0KPj4+IEBAIC04MDksMTAgKzgxMyw2IEBAIHN0YXRpYyB2b2lkIGFzcGVlZF92 aWRlb19nZXRfcmVzb2x1dGlvbihzdHJ1Y3QgYXNwZWVkX3ZpZGVvICp2aWRlbykKPj4+ICAgICAg ICAgICAgICAgICAgICAgICAgICByZXR1cm47Cj4+PiAgICAgICAgICAgICAgICAgIH0KPj4+Cj4+ PiAtICAgICAgICAgICAgICAgLyogRGlzYWJsZSBtb2RlIGRldGVjdCBpbiBvcmRlciB0byByZS10 cmlnZ2VyICovCj4+PiAtICAgICAgICAgICAgICAgYXNwZWVkX3ZpZGVvX3VwZGF0ZSh2aWRlbywg VkVfU0VRX0NUUkwsCj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBWRV9T RVFfQ1RSTF9UUklHX01PREVfREVULCAwKTsKPj4+IC0KPj4+ICAgICAgICAgICAgICAgICAgYXNw ZWVkX3ZpZGVvX2NoZWNrX2FuZF9zZXRfcG9sYXJpdHkodmlkZW8pOwo+Pj4KPj4+ICAgICAgICAg ICAgICAgICAgYXNwZWVkX3ZpZGVvX2VuYWJsZV9tb2RlX2RldGVjdCh2aWRlbyk7Cj4+PiAtLQo+ Pj4gMi4yNS4xCj4+PgotLSAKQmVzdCBSZWdhcmRzCkphbW15CgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68BB4C433EF for ; Wed, 3 Nov 2021 05:04:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5129560F70 for ; Wed, 3 Nov 2021 05:04:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230462AbhKCFGr (ORCPT ); Wed, 3 Nov 2021 01:06:47 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:46533 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230369AbhKCFGq (ORCPT ); Wed, 3 Nov 2021 01:06:46 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1A34dkWW071525; Wed, 3 Nov 2021 12:39:46 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Nov 2021 13:02:37 +0800 Message-ID: <3a40bb81-2c6e-47e3-fb85-e615aecd129a@aspeedtech.com> Date: Wed, 3 Nov 2021 13:02:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v2] media: aspeed: fix mode-detect always time out at 2nd run Content-Language: en-US To: Joel Stanley CC: Eddie James , Mauro Carvalho Chehab , Andrew Jeffery , "linux-media@vger.kernel.org" , OpenBMC Maillist , Linux ARM , linux-aspeed , Linux Kernel Mailing List , Paul Menzel References: <20211103011357.22067-1-jammy_huang@aspeedtech.com> From: Jammy Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1A34dkWW071525 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Dear Joel, Sure. Thanks for your reminder. On 2021/11/3 上午 09:53, Joel Stanley wrote: > On Wed, 3 Nov 2021 at 01:47, Joel Stanley wrote: >> On Wed, 3 Nov 2021 at 01:13, Jammy Huang wrote: >>> aspeed_video_get_resolution() will try to do res-detect again if the >>> timing got in last try is invalid. But it will always time out because >>> VE_SEQ_CTRL_TRIG_MODE_DET is only cleared after 1st mode-detect. >>> >>> To fix the problem, just clear VE_SEQ_CTRL_TRIG_MODE_DET before setting >>> it in aspeed_video_enable_mode_detect(). >>> >>> Signed-off-by: Jammy Huang >>> Acked-by: Paul Menzel >> Reviewed-by: Joel Stanley > When applying, can we please have this tag added: > > Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver") > > Cheers, > > Joel > > >>> --- >>> v2: >>> - update commit message >>> --- >>> drivers/media/platform/aspeed-video.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >>> index 5ffbabf884eb..fea5e4d0927e 100644 >>> --- a/drivers/media/platform/aspeed-video.c >>> +++ b/drivers/media/platform/aspeed-video.c >>> @@ -518,6 +518,10 @@ static void aspeed_video_enable_mode_detect(struct aspeed_video *video) >>> aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, >>> VE_INTERRUPT_MODE_DETECT); >>> >>> + /* Disable mode detect in order to re-trigger */ >>> + aspeed_video_update(video, VE_SEQ_CTRL, >>> + VE_SEQ_CTRL_TRIG_MODE_DET, 0); >>> + >>> /* Trigger mode detect */ >>> aspeed_video_update(video, VE_SEQ_CTRL, 0, VE_SEQ_CTRL_TRIG_MODE_DET); >>> } >>> @@ -809,10 +813,6 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) >>> return; >>> } >>> >>> - /* Disable mode detect in order to re-trigger */ >>> - aspeed_video_update(video, VE_SEQ_CTRL, >>> - VE_SEQ_CTRL_TRIG_MODE_DET, 0); >>> - >>> aspeed_video_check_and_set_polarity(video); >>> >>> aspeed_video_enable_mode_detect(video); >>> -- >>> 2.25.1 >>> -- Best Regards Jammy