From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3698553412642520517==" MIME-Version: 1.0 From: 吴俊文 To: kbuild-all@lists.01.org Subject: Re: [PATCH v1] char: misc:use DEFINE_PROC_SHOW_ATTRIBUTE micro to simplify misc proc_fops Date: Sun, 27 Mar 2022 22:02:30 +0800 Message-ID: <3a40c441.27e9.17fcbaf7e12.Coremail.wudaemon@163.com> In-Reply-To: <202203271414.XUS8IhaO-lkp@intel.com> List-Id: --===============3698553412642520517== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Dear robot: sorry, I have noticed the error,I will commit new patch to corret it = Thanks At 2022-03-27 14:16:04, "kernel test robot" wrote: >Hi wujunwen, > >Thank you for the patch! Yet something to improve: > >[auto build test ERROR on char-misc/char-misc-testing] >[also build test ERROR on soc/for-next linux/master linus/master v5.17 nex= t-20220325] >[If your patch is applied to the wrong git tree, kindly drop us a note. >And when submitting patch, we suggest to use '--base' as documented in >https://git-scm.com/docs/git-format-patch] > >url: https://github.com/intel-lab-lkp/linux/commits/wujunwen/char-misc-= use-DEFINE_PROC_SHOW_ATTRIBUTE-micro-to-simplify-misc-proc_fops/20220327-12= 0053 >base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.g= it 37fd83916da2e4cae03d350015c82a67b1b334c4 >config: hexagon-randconfig-r045-20220327 (https://download.01.org/0day-ci/= archive/20220327/202203271414.XUS8IhaO-lkp(a)intel.com/config) >compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0f6d9= 501cf49ce02937099350d08f20c4af86f3d) >reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin= /make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/738cb3f8808411f37a= d8cb6c2529c6686a87eddf > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review wujunwen/char-misc-use-DEFINE_PRO= C_SHOW_ATTRIBUTE-micro-to-simplify-misc-proc_fops/20220327-120053 > git checkout 738cb3f8808411f37ad8cb6c2529c6686a87eddf > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W= =3D1 O=3Dbuild_dir ARCH=3Dhexagon SHELL=3D/bin/bash drivers/char/ > >If you fix the issue, kindly add following tag as appropriate >Reported-by: kernel test robot > >All errors (new ones prefixed by >>): > >>> drivers/char/misc.c:254:38: error: use of undeclared identifier 'misc_p= roc_ops'; did you mean 'misc_fops'? > ret =3D proc_create("misc", 0, NULL, &misc_proc_ops); > ^~~~~~~~~~~~~ > misc_fops > drivers/char/misc.c:132:37: note: 'misc_fops' declared here > static const struct file_operations misc_fops =3D { > ^ > 1 error generated. > > >vim +254 drivers/char/misc.c > > 248 = > 249 static int __init misc_init(void) > 250 { > 251 int err; > 252 struct proc_dir_entry *ret; > 253 = > > 254 ret =3D proc_create("misc", 0, NULL, &misc_proc_ops); > >-- = >0-DAY CI Kernel Test Service >https://01.org/lkp --===============3698553412642520517== Content-Type: text/html MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="attachment.htm" PGRpdiBzdHlsZT0ibGluZS1oZWlnaHQ6MS43O2NvbG9yOiMwMDAwMDA7Zm9udC1zaXplOjE0cHg7 Zm9udC1mYW1pbHk6QXJpYWwiPjxkaXYgc3R5bGU9Im1hcmdpbjogMDsiPkRlYXIgcm9ib3Q6PC9k aXY+PGRpdiBzdHlsZT0ibWFyZ2luOiAwOyI+c29ycnksIEkgaGF2ZSBub3RpY2VkIHRoZSBlcnJv cixJIHdpbGwgY29tbWl0IG5ldyBwYXRjaCB0byBjb3JyZXQgaXQmbmJzcDs8L2Rpdj48ZGl2IHN0 eWxlPSJtYXJnaW46IDA7Ij5UaGFua3M8L2Rpdj48cCBzdHlsZT0ibWFyZ2luOiAwOyI+PGJyPjwv cD48cCBzdHlsZT0ibWFyZ2luOiAwOyI+PGJyPjwvcD48cCBzdHlsZT0ibWFyZ2luOiAwOyI+PGJy PjwvcD48cCBzdHlsZT0ibWFyZ2luOiAwOyI+PGJyPjwvcD48ZGl2IHN0eWxlPSJwb3NpdGlvbjpy ZWxhdGl2ZTt6b29tOjEiPjwvZGl2PjxkaXYgaWQ9ImRpdk5ldGVhc2VNYWlsQ2FyZCI+PC9kaXY+ PHAgc3R5bGU9Im1hcmdpbjogMDsiPjxicj48L3A+PHByZT48YnI+QXQgMjAyMi0wMy0yNyAxNDox NjowNCwgImtlcm5lbCB0ZXN0IHJvYm90IiAmbHQ7bGtwQGludGVsLmNvbSZndDsgd3JvdGU6CiZn dDtIaSB3dWp1bndlbiwKJmd0OwomZ3Q7VGhhbmsgeW91IGZvciB0aGUgcGF0Y2ghIFlldCBzb21l dGhpbmcgdG8gaW1wcm92ZToKJmd0OwomZ3Q7W2F1dG8gYnVpbGQgdGVzdCBFUlJPUiBvbiBjaGFy LW1pc2MvY2hhci1taXNjLXRlc3RpbmddCiZndDtbYWxzbyBidWlsZCB0ZXN0IEVSUk9SIG9uIHNv Yy9mb3ItbmV4dCBsaW51eC9tYXN0ZXIgbGludXMvbWFzdGVyIHY1LjE3IG5leHQtMjAyMjAzMjVd CiZndDtbSWYgeW91ciBwYXRjaCBpcyBhcHBsaWVkIHRvIHRoZSB3cm9uZyBnaXQgdHJlZSwga2lu ZGx5IGRyb3AgdXMgYSBub3RlLgomZ3Q7QW5kIHdoZW4gc3VibWl0dGluZyBwYXRjaCwgd2Ugc3Vn Z2VzdCB0byB1c2UgJy0tYmFzZScgYXMgZG9jdW1lbnRlZCBpbgomZ3Q7aHR0cHM6Ly9naXQtc2Nt LmNvbS9kb2NzL2dpdC1mb3JtYXQtcGF0Y2hdCiZndDsKJmd0O3VybDogICAgaHR0cHM6Ly9naXRo dWIuY29tL2ludGVsLWxhYi1sa3AvbGludXgvY29tbWl0cy93dWp1bndlbi9jaGFyLW1pc2MtdXNl LURFRklORV9QUk9DX1NIT1dfQVRUUklCVVRFLW1pY3JvLXRvLXNpbXBsaWZ5LW1pc2MtcHJvY19m b3BzLzIwMjIwMzI3LTEyMDA1MwomZ3Q7YmFzZTogICBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1 Yi9zY20vbGludXgva2VybmVsL2dpdC9ncmVna2gvY2hhci1taXNjLmdpdCAzN2ZkODM5MTZkYTJl NGNhZTAzZDM1MDAxNWM4MmE2N2IxYjMzNGM0CiZndDtjb25maWc6IGhleGFnb24tcmFuZGNvbmZp Zy1yMDQ1LTIwMjIwMzI3IChodHRwczovL2Rvd25sb2FkLjAxLm9yZy8wZGF5LWNpL2FyY2hpdmUv MjAyMjAzMjcvMjAyMjAzMjcxNDE0LlhVUzhJaGFPLWxrcEBpbnRlbC5jb20vY29uZmlnKQomZ3Q7 Y29tcGlsZXI6IGNsYW5nIHZlcnNpb24gMTUuMC4wIChodHRwczovL2dpdGh1Yi5jb20vbGx2bS9s bHZtLXByb2plY3QgMGY2ZDk1MDFjZjQ5Y2UwMjkzNzA5OTM1MGQwOGYyMGM0YWY4NmYzZCkKJmd0 O3JlcHJvZHVjZSAodGhpcyBpcyBhIFc9MSBidWlsZCk6CiZndDsgICAgICAgIHdnZXQgaHR0cHM6 Ly9yYXcuZ2l0aHVidXNlcmNvbnRlbnQuY29tL2ludGVsL2xrcC10ZXN0cy9tYXN0ZXIvc2Jpbi9t YWtlLmNyb3NzIC1PIH4vYmluL21ha2UuY3Jvc3MKJmd0OyAgICAgICAgY2htb2QgK3ggfi9iaW4v bWFrZS5jcm9zcwomZ3Q7ICAgICAgICAjIGh0dHBzOi8vZ2l0aHViLmNvbS9pbnRlbC1sYWItbGtw L2xpbnV4L2NvbW1pdC83MzhjYjNmODgwODQxMWYzN2FkOGNiNmMyNTI5YzY2ODZhODdlZGRmCiZn dDsgICAgICAgIGdpdCByZW1vdGUgYWRkIGxpbnV4LXJldmlldyBodHRwczovL2dpdGh1Yi5jb20v aW50ZWwtbGFiLWxrcC9saW51eAomZ3Q7ICAgICAgICBnaXQgZmV0Y2ggLS1uby10YWdzIGxpbnV4 LXJldmlldyB3dWp1bndlbi9jaGFyLW1pc2MtdXNlLURFRklORV9QUk9DX1NIT1dfQVRUUklCVVRF LW1pY3JvLXRvLXNpbXBsaWZ5LW1pc2MtcHJvY19mb3BzLzIwMjIwMzI3LTEyMDA1MwomZ3Q7ICAg ICAgICBnaXQgY2hlY2tvdXQgNzM4Y2IzZjg4MDg0MTFmMzdhZDhjYjZjMjUyOWM2Njg2YTg3ZWRk ZgomZ3Q7ICAgICAgICAjIHNhdmUgdGhlIGNvbmZpZyBmaWxlIHRvIGxpbnV4IGJ1aWxkIHRyZWUK Jmd0OyAgICAgICAgbWtkaXIgYnVpbGRfZGlyCiZndDsgICAgICAgIENPTVBJTEVSX0lOU1RBTExf UEFUSD0kSE9NRS8wZGF5IENPTVBJTEVSPWNsYW5nIG1ha2UuY3Jvc3MgVz0xIE89YnVpbGRfZGly IEFSQ0g9aGV4YWdvbiBTSEVMTD0vYmluL2Jhc2ggZHJpdmVycy9jaGFyLwomZ3Q7CiZndDtJZiB5 b3UgZml4IHRoZSBpc3N1ZSwga2luZGx5IGFkZCBmb2xsb3dpbmcgdGFnIGFzIGFwcHJvcHJpYXRl CiZndDtSZXBvcnRlZC1ieToga2VybmVsIHRlc3Qgcm9ib3QgJmx0O2xrcEBpbnRlbC5jb20mZ3Q7 CiZndDsKJmd0O0FsbCBlcnJvcnMgKG5ldyBvbmVzIHByZWZpeGVkIGJ5ICZndDsmZ3Q7KToKJmd0 OwomZ3Q7Jmd0OyZndDsgZHJpdmVycy9jaGFyL21pc2MuYzoyNTQ6Mzg6IGVycm9yOiB1c2Ugb2Yg dW5kZWNsYXJlZCBpZGVudGlmaWVyICdtaXNjX3Byb2Nfb3BzJzsgZGlkIHlvdSBtZWFuICdtaXNj X2ZvcHMnPwomZ3Q7ICAgICAgICAgICByZXQgPSBwcm9jX2NyZWF0ZSgibWlzYyIsIDAsIE5VTEws ICZhbXA7bWlzY19wcm9jX29wcyk7CiZndDsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn4KJmd0OyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgbWlzY19mb3BzCiZndDsgICBkcml2ZXJzL2NoYXIvbWlz Yy5jOjEzMjozNzogbm90ZTogJ21pc2NfZm9wcycgZGVjbGFyZWQgaGVyZQomZ3Q7ICAgc3RhdGlj IGNvbnN0IHN0cnVjdCBmaWxlX29wZXJhdGlvbnMgbWlzY19mb3BzID0gewomZ3Q7ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgomZ3Q7ICAgMSBlcnJvciBnZW5lcmF0ZWQu CiZndDsKJmd0OwomZ3Q7dmltICsyNTQgZHJpdmVycy9jaGFyL21pc2MuYwomZ3Q7CiZndDsgICAy NDgJCiZndDsgICAyNDkJc3RhdGljIGludCBfX2luaXQgbWlzY19pbml0KHZvaWQpCiZndDsgICAy NTAJewomZ3Q7ICAgMjUxCQlpbnQgZXJyOwomZ3Q7ICAgMjUyCQlzdHJ1Y3QgcHJvY19kaXJfZW50 cnkgKnJldDsKJmd0OyAgIDI1MwkKJmd0OyAmZ3Q7IDI1NAkJcmV0ID0gcHJvY19jcmVhdGUoIm1p c2MiLCAwLCBOVUxMLCAmYW1wO21pc2NfcHJvY19vcHMpOwomZ3Q7CiZndDstLSAKJmd0OzAtREFZ IENJIEtlcm5lbCBUZXN0IFNlcnZpY2UKJmd0O2h0dHBzOi8vMDEub3JnL2xrcAo8L3ByZT48L2Rp dj48YnI+PGJyPjxzcGFuIHRpdGxlPSJuZXRlYXNlZm9vdGVyIj48cD4mbmJzcDs8L3A+PC9zcGFu Pg== --===============3698553412642520517==--