From mboxrd@z Thu Jan 1 00:00:00 1970 From: skannan@codeaurora.org (skannan at codeaurora.org) Date: Tue, 27 Feb 2018 15:15:46 -0800 Subject: [PATCH v1 2/2] perf/core: Add support for PMUs that can be read from any CPU In-Reply-To: <20180227114313.mtvyo6rdavqfj2hy@lakrids.cambridge.arm.com> References: <1519431578-11995-1-git-send-email-skannan@codeaurora.org> <1519431578-11995-2-git-send-email-skannan@codeaurora.org> <20180225143802.denbkubqjg2dc7af@salmiak> <90e7ff7d7dc1054db356fb1740ddb990@codeaurora.org> <20180227114313.mtvyo6rdavqfj2hy@lakrids.cambridge.arm.com> Message-ID: <3a57c8261e0f10b72e0533c39d9abe19@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2018-02-27 03:43, Mark Rutland wrote: > On Mon, Feb 26, 2018 at 06:11:45PM -0800, skannan at codeaurora.org wrote: >> On 2018-02-25 06:38, Mark Rutland wrote: >> > On Fri, Feb 23, 2018 at 04:19:38PM -0800, Saravana Kannan wrote: >> > > Some PMUs events can be read from any CPU. So allow the PMU to mark >> > > events as such. For these events, we don't need to reject reads or >> > > make smp calls to the event's CPU and cause unnecessary wake ups. >> > > >> > > Good examples of such events would be events from caches shared across >> > > all CPUs. >> > >> > I think that if we need to generalize PERF_EV_CAP_READ_ACTIVE_PKG, it >> > would be >> > better to give events a pointer to a cpumask. That could then cover all >> > cases >> > quite trivially: >> > >> > static int __perf_event_read_cpu(struct perf_event *event, int >> > event_cpu) >> > { >> > int local_cpu = smp_processor_id(); >> > >> > if (event->read_mask && >> > cpumask_test_cpu(local_cpu, event->read_mask)) >> > event_cpu = local_cpu; >> > >> > return event_cpu; >> > } >> >> This is a good improvement on my attempt. If I send a patch for this, >> is >> that something you'd be willing to incorporate into your patch set and >> make >> sure the DSU pmu driver handles it correctly? > > As I commented, I don't think that willl work without more invasive > changes as the DSU PMU's pmu::read() function has side effects on > hwc->prev_count and event_count, and could race with an IRQ handler on > another CPU. > > Is the IPI really a problem in practice? > There are a bunch of cases, but the simplest one is if you try to collect DSU stats (for analysis) while measuring power, it completely messes up the power measurements. Thanks, Saravana From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751996AbeB0XPs (ORCPT ); Tue, 27 Feb 2018 18:15:48 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:38808 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbeB0XPr (ORCPT ); Tue, 27 Feb 2018 18:15:47 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 27 Feb 2018 15:15:46 -0800 From: skannan@codeaurora.org To: Mark Rutland Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , avilaj@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] perf/core: Add support for PMUs that can be read from any CPU In-Reply-To: <20180227114313.mtvyo6rdavqfj2hy@lakrids.cambridge.arm.com> References: <1519431578-11995-1-git-send-email-skannan@codeaurora.org> <1519431578-11995-2-git-send-email-skannan@codeaurora.org> <20180225143802.denbkubqjg2dc7af@salmiak> <90e7ff7d7dc1054db356fb1740ddb990@codeaurora.org> <20180227114313.mtvyo6rdavqfj2hy@lakrids.cambridge.arm.com> Message-ID: <3a57c8261e0f10b72e0533c39d9abe19@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-02-27 03:43, Mark Rutland wrote: > On Mon, Feb 26, 2018 at 06:11:45PM -0800, skannan@codeaurora.org wrote: >> On 2018-02-25 06:38, Mark Rutland wrote: >> > On Fri, Feb 23, 2018 at 04:19:38PM -0800, Saravana Kannan wrote: >> > > Some PMUs events can be read from any CPU. So allow the PMU to mark >> > > events as such. For these events, we don't need to reject reads or >> > > make smp calls to the event's CPU and cause unnecessary wake ups. >> > > >> > > Good examples of such events would be events from caches shared across >> > > all CPUs. >> > >> > I think that if we need to generalize PERF_EV_CAP_READ_ACTIVE_PKG, it >> > would be >> > better to give events a pointer to a cpumask. That could then cover all >> > cases >> > quite trivially: >> > >> > static int __perf_event_read_cpu(struct perf_event *event, int >> > event_cpu) >> > { >> > int local_cpu = smp_processor_id(); >> > >> > if (event->read_mask && >> > cpumask_test_cpu(local_cpu, event->read_mask)) >> > event_cpu = local_cpu; >> > >> > return event_cpu; >> > } >> >> This is a good improvement on my attempt. If I send a patch for this, >> is >> that something you'd be willing to incorporate into your patch set and >> make >> sure the DSU pmu driver handles it correctly? > > As I commented, I don't think that willl work without more invasive > changes as the DSU PMU's pmu::read() function has side effects on > hwc->prev_count and event_count, and could race with an IRQ handler on > another CPU. > > Is the IPI really a problem in practice? > There are a bunch of cases, but the simplest one is if you try to collect DSU stats (for analysis) while measuring power, it completely messes up the power measurements. Thanks, Saravana