From: Ping-Ke Shih <pkshih@realtek.com>
To: "Mingyen Hsieh (謝明諺)" <Mingyen.Hsieh@mediatek.com>,
"nbd@nbd.name" <nbd@nbd.name>,
"lorenzo@kernel.org" <lorenzo@kernel.org>
Cc: "Allan Wang (王家偉)" <Allan.Wang@mediatek.com>,
"Eric-SY Chang (張書源)" <Eric-SY.Chang@mediatek.com>,
"Deren Wu (武德仁)" <Deren.Wu@mediatek.com>,
"Ryder Lee" <Ryder.Lee@mediatek.com>,
"Quan Zhou (周全)" <Quan.Zhou@mediatek.com>,
"Michael Lo (羅璧章)" <Michael.Lo@mediatek.com>,
"Shayne Chen (陳軒丞)" <Shayne.Chen@mediatek.com>,
"Sean Wang" <Sean.Wang@mediatek.com>,
"Leon Yen (顏良儒)" <Leon.Yen@mediatek.com>,
"KM Lin (林昆民)" <km.lin@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH v2 1/6] wifi: mt76: mt7925: load the appropriate CLC data based on hardware type
Date: Wed, 5 Mar 2025 01:00:08 +0000 [thread overview]
Message-ID: <3a874973725a4368885e3eafeea3479e@realtek.com> (raw)
In-Reply-To: <c3fcef13b2c626be49cf160e53fc93fcfe8af9b8.camel@mediatek.com>
> > > + struct evt {
> > > + u8 rsv[4];
> > > +
> > > + __le16 tag;
> > > + __le16 len;
> > > +
> > > + __le32 ver;
> > > + __le32 addr;
> > > + __le32 valid;
> > > + __le32 size;
> > > + __le32 magic_num;
> > > + __le32 type;
> > > + __le32 rsv1[4];
> > > + u8 data[32];
> > > + } __packed * res;
> >
> > nit: no need space between * and res, i.e. "__packed *res".
> >
> Hi Ping-Ke,
>
> I also think this is better, but this was suggested to me by
> script/checkpatch.pl.
>
checkpatch says "CHECK:SPACING: spaces preferred around that '*'" for this
case, because it treats as a binary operator, so this is a false alarm.
By the way, "git grep "__packed \* " drivers/net/wireless/" can see many
similar instances I guess they are also suggested by checkpatch.
prev parent reply other threads:[~2025-03-05 1:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 6:28 [PATCH v2 1/6] wifi: mt76: mt7925: load the appropriate CLC data based on hardware type Mingyen Hsieh
2025-03-04 6:28 ` [PATCH v2 2/6] wifi: mt76: mt7925: add EHT control support based on the CLC data Mingyen Hsieh
2025-03-04 9:10 ` Ping-Ke Shih
2025-03-04 9:34 ` Mingyen Hsieh (謝明諺)
2025-03-05 1:21 ` Ping-Ke Shih
2025-03-05 9:32 ` Mingyen Hsieh (謝明諺)
2025-03-06 0:41 ` Ping-Ke Shih
2025-03-04 6:28 ` [PATCH v2 3/6] wifi: mt76: mt7925: update the channel usage when the regd domain changed Mingyen Hsieh
2025-03-04 9:13 ` Ping-Ke Shih
2025-03-04 6:28 ` [PATCH v2 4/6] wifi: mt76: mt7925: remove unused acpi function for clc Mingyen Hsieh
2025-03-04 6:28 ` [PATCH v2 5/6] wifi: mt76: mt792x: extend MTCL of APCI to version3 for EHT control Mingyen Hsieh
2025-03-04 6:28 ` [PATCH v2 6/6] wifi: mt76: mt7925: add MTCL support to enhance the reulatory compliance Mingyen Hsieh
2025-03-04 9:06 ` [PATCH v2 1/6] wifi: mt76: mt7925: load the appropriate CLC data based on hardware type Ping-Ke Shih
2025-03-04 9:37 ` Mingyen Hsieh (謝明諺)
2025-03-05 1:00 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a874973725a4368885e3eafeea3479e@realtek.com \
--to=pkshih@realtek.com \
--cc=Allan.Wang@mediatek.com \
--cc=Deren.Wu@mediatek.com \
--cc=Eric-SY.Chang@mediatek.com \
--cc=Leon.Yen@mediatek.com \
--cc=Michael.Lo@mediatek.com \
--cc=Mingyen.Hsieh@mediatek.com \
--cc=Quan.Zhou@mediatek.com \
--cc=Ryder.Lee@mediatek.com \
--cc=Sean.Wang@mediatek.com \
--cc=Shayne.Chen@mediatek.com \
--cc=km.lin@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.