Re: [bitbake-devel] [PATCH 1/1] fetch2/git.py: Try without '.git' suffix firstly

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2024-05-15 at 17:57 +0800, Robert Yang via lists.openembedded.org wrote:
> Hi Quentin,
> 
> On 5/15/24 17:35, Quentin Schulz wrote:
> > Hi Robert,
> > 
> > On 5/15/24 11:26 AM, Robert Yang via lists.openembedded.org wrote:
> > > From: Robert Yang <liezhi.yang@windriver.com>
> > > 
> > > If the repo on server is foo.git, both of the following commands
> > > will work:
> > > 1) $ git clone <url>/foo.git
> > > 2) $ git clone <url>/foo
> > > But only the second command works if the repo server is foo
> > > (without .git suffix), so try without '.git' suffix firstly.
> > > 
> > 
> > Shouldn't the SRC_URI in the recipe be fixed instead of the git fetcher? Which 
> > use case do we need to support here? Something to do with mirroring maybe
> The usage is related to repo command + http/https mirror:
> 
> * The foo.git on http/https MIRROR works with do_fetch
> * But 'repo' command always add a '.git' suffix to the reponame, the foo.git
> will be saved as foo.git.git on local disk, and do_fetch would not work with
> the local mirror.
> 
> Our solution is rename foo.git to foo on http/https mirror, and apply this patch
> to make both http(s) and local mirror work with repo command.
> 
> It's a little special to our Wind River Linux, and we need send the patch to
> mailing list for Yocto compliance.

I'm with Quentin, the SRC_URIs should be fixed or this should be in
repo specific codepaths. We're not adding a workaround like that into
the git fetcher.

Cheers,

Richard