From: Finn Callies <fcallies@linux.ibm.com>
To: Harald Freudenberger <freude@linux.ibm.com>,
dengler@linux.ibm.com, ifranzki@linux.ibm.com
Cc: linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 2/2] s390/crypto: Explicit scrub temp buffer in PAES ctr mode algorithm
Date: Thu, 6 Aug 2026 06:50:49 +0200 [thread overview]
Message-ID: <3aca074a-c054-4b41-a038-fd75fa228f80@linux.ibm.com> (raw)
In-Reply-To: <20260805155458.14925-3-freude@linux.ibm.com>
On 05.08.26 17:54, Harald Freudenberger wrote:
> In function ctr_paes_do_crypt() there is a buffer used to process
> remaining bytes < AES_BLOCK_SIZE. This buffer was not scrubbed and
> thus could lead to expose of unwanted data.
>
> On exit of the function unconditionally scrub this buffer to avoid
> exposure of maybe sensitive data.
>
> Fixes: 6cd87cb5ef6c ("s390/crypto: Rework protected key AES for true asynch support")
> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
> Cc: stable@vger.kernel.org # 6.16+
> ---
> arch/s390/crypto/paes_s390.c | 1 +
> 1 file changed, 1 insertion(+)
[ snip ]
LGTM
Reviewed-by: Finn Callies <fcallies@linux.ibm.com>
next prev parent reply other threads:[~2026-08-06 4:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 15:54 [PATCH v2 0/2] PAES - Fix rc handling at skcipher_walk_done Harald Freudenberger
2026-08-05 15:54 ` [PATCH v2 1/2] s390/crypto: Fix return code handling at skcipher_walk_done in PAES algorithms Harald Freudenberger
2026-08-06 4:50 ` Finn Callies
2026-08-11 7:00 ` Holger Dengler
2026-08-05 15:54 ` [PATCH v2 2/2] s390/crypto: Explicit scrub temp buffer in PAES ctr mode algorithm Harald Freudenberger
2026-08-06 4:50 ` Finn Callies [this message]
2026-08-11 8:50 ` Holger Dengler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aca074a-c054-4b41-a038-fd75fa228f80@linux.ibm.com \
--to=fcallies@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=dengler@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=ifranzki@linux.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.