From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 969BDC02192 for ; Mon, 3 Feb 2025 16:33:49 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.880867.1290958 (Exim 4.92) (envelope-from ) id 1tezOK-0003G8-8q; Mon, 03 Feb 2025 16:33:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 880867.1290958; Mon, 03 Feb 2025 16:33:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tezOK-0003G1-6O; Mon, 03 Feb 2025 16:33:44 +0000 Received: by outflank-mailman (input) for mailman id 880867; Mon, 03 Feb 2025 16:33:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tezOI-00031N-L0 for xen-devel@lists.xenproject.org; Mon, 03 Feb 2025 16:33:42 +0000 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [2a00:1450:4864:20::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a06c79c3-e24c-11ef-99a4-01e77a169b0f; Mon, 03 Feb 2025 17:33:41 +0100 (CET) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-ab2c9b8aecaso785035266b.0 for ; Mon, 03 Feb 2025 08:33:41 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6e49ff269sm775735966b.118.2025.02.03.08.33.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Feb 2025 08:33:39 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a06c79c3-e24c-11ef-99a4-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1738600420; x=1739205220; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=xU9FE5UikwYpsW1feAk3el5qgiM8RTKMmdxwjd+Fq5U=; b=PAVj7QfGJ4rDcoZ6dR+ZcUCJKHWUGSqwzemCUr2X+fsV2HmfDHgae4VVbhcblvZMau 8ZlnT7NEeV4SwclHat5vkTcDpja8aWsXaNPZFrLRqmaEZjuWEqsQ0rY0oOrnqrkqQogk AlKH31nshTeskdKB49rh7EKfcixHqcUfepxP+oXnyakOivf9PMzkXePnn1nchTY5XvSf y0HmcqZCcXjFchAWLAtbfZQJAW6PivDgqJfe0UDDTbmW7Mg0RpK63ySMQQTx11pVSDfc V0gAkH0n5AoRDkU0JuCqUvdUMqWf2ySShKe8ftul7dsYLHJ/oTEXA4ePSmZPE1s1nf30 nN2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738600420; x=1739205220; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xU9FE5UikwYpsW1feAk3el5qgiM8RTKMmdxwjd+Fq5U=; b=o/3grm7k5l9/LeotXH1+jWETJER1V7Zwk7ujppJqFRhsMom1mqwsK6iLeZUTTHEtNW nZWZcZ3dqoKZ2t0HVGqvBk4UxZmOpTV/z/dueRS9hZf+9MKRtu9rJzgtBQ7hjrUl2nzo bXokvHJg21S1A1Mmp8CwyGtCle7LY9H1EmoXzpxaQHQfhan2MTI26zdRzdUkXqVICQZ2 MBZw/DrFZFp06uROy8ApDhUFI/XpfUIxqoESd7Pq00li4OibNlK6+ML/oJIEsZIb1omu Su8blQtlTAUvWeMLx5Vy4WTBewUvMLruIDeqtld1I14Rdz65PGdjOGCFecDaZFQe0eo9 TnPw== X-Forwarded-Encrypted: i=1; AJvYcCUZju+Um9KxVGuHoDQb+RyK3Zu9tYDQeONWfWF+3yy2jcSbBomTyoHNAlpMPE18BrgE3xAbhiaLYyg=@lists.xenproject.org X-Gm-Message-State: AOJu0YzbRrGSng0l+HtGzO2MImgi/rSrxysChu1nB5R6GOUAk0Pk7R/9 Xjz9EdR5Nc7I34Ca6yimXtHrLAB6+lGk4uMpQCfASfACytuyTIYvWoZrUdiHKg== X-Gm-Gg: ASbGncsgFsm8KooDvsrPtejdCb8GeOv6tGUy4dC+aRiDON+IsRBAy7MpIgUkHAx0nsF IYEoISCcvMdExC9MPOE0+IzsuQhbU1h6x0nfU5fpUHdfLTFqc4XCubZKh/APF1dIjCHTzDRV47u kly6fl0olPmAhRH7K6LnvUTw9dtr8gEofiqnjV04kEIwMe7uGOp4lnUmS+yvc7I49swfJC2/r06 67lpGoX3Q9d15/crnYMDTysITKoAtU1ZS3yNL7nzv315B2xiF9jCY+aSvH1NNy+QgcAtjiN12Vu 5wNGZc5Pgk8TsveeoemIRUrU1/3QNV5dM06E5rd4ChHQeEbyrS+prgGbaAKvblZb+UeU2hFmrV9 K X-Google-Smtp-Source: AGHT+IE/jBkjXNkbQGUUm/mY78YJk4uarbpJUjMyCQUXnXL+n9EMK0ToQ48y7U+GARnkRtCTDAcCZw== X-Received: by 2002:a17:906:f58b:b0:ab7:3e27:ff04 with SMTP id a640c23a62f3a-ab73e28080bmr285408666b.3.1738600419975; Mon, 03 Feb 2025 08:33:39 -0800 (PST) Message-ID: <3adb5869-fb96-4b8e-8423-7f9eccd2f6ca@suse.com> Date: Mon, 3 Feb 2025 17:33:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/9] asm-generic: move parts of Arm's asm/kernel.h to asm-generic To: Oleksii Kurochko Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , xen-devel@lists.xenproject.org References: <6404cb5ae077909cbfdf3860d38c701c65547b56.1736334615.git.oleksii.kurochko@gmail.com> <2f14762e-d302-483c-8adb-3223e6290de0@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03.02.2025 16:34, Oleksii Kurochko wrote: > > On 1/27/25 12:15 PM, Jan Beulich wrote: >> On 08.01.2025 12:13, Oleksii Kurochko wrote: >>> Move the following parts to asm-generic with the following changes: >>> - struct kernel_info: >>> - Create arch_kernel_info for arch specific kernel information. >>> At the moment, it contains domain_type for Arm. >>> - Rename vpl011 to vuart to have more generic name suitable for other archs. >>> - s/phandle_gic/phandle_intc to have more generic name suitable for other >>> archs. >>> - Make text_offset of zimage structure available for RISCV_64. >>> - Wrap by `#ifdef KERNEL_INFO_SHM_MEM_INIT` definition of KERNEL_SHM_MEM_INIT >>> and wrap by `#ifndef KERNEL_INFO_INIT` definition of KERNEL_INFO_INIT to have >>> ability to override KERNEL_INFO_SHM_MEM_INIT for arch in case it doesn't >>> want to use generic one. >>> - All other parts are left as is from Arm's asm/kernel.h >>> >>> Because of the changes in struct kernel_info the correspondent parts of Arm's >>> code are updated. >>> >>> As part of this patch the following clean up happens: >>> - Drop asm/setup.h from asm/kernel.h as nothing depends from it. >>> Add inclusion of asm/setup.h for a code which uses device_tree_get_reg() to >>> avoid compilation issues for CONFIG_STATIC_MEMORY and CONFIG_STATIC_SHM. >>> >>> Signed-off-by: Oleksii Kurochko >> I question that what is being moved qualifies for asm-generic, an in particular >> for a header named kernel.h. Some of what you move may make sense to move to >> dom0less-build.h instead. But everything that doesn't fit there needs to find >> a different home, imo. > > It doesn't clear what then should be in kernel.h, I did in this way to not have a problem with header inclusion > during the build of Arm. > > Definitions DOM0LESSS_* could be moved to dom0less-build.h, all other doesn't really connected only to dom0less feature > and could be re-used for dom0 so it seems like it should leave in a separate header ( if kernel.h isn't good for it ). > > Probably kernel.h shouldn't leave in asm-generic as nothing architecture specific is in it, Well, kernel.h under asm-generic/ is somewhat odd in the first place. > but on the other hand, will it > be okay to have something in xen/include if it isn't supported by all architectures? It can be okay; it depends on a number of factors. Jan