From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>, Pavel Begunkov <asml.silence@gmail.com>
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH 1/2] io_uring/timeout: READ_ONCE sqe->addr
Date: Tue, 24 Feb 2026 11:28:02 -0700 [thread overview]
Message-ID: <3aec1803-e148-47f5-bc18-c88e8cc96123@kernel.dk> (raw)
In-Reply-To: <aZ3WH6S7TjyvPd5V@kbusch-mbp>
On 2/24/26 9:47 AM, Keith Busch wrote:
> On Tue, Feb 24, 2026 at 04:12:10PM +0000, Pavel Begunkov wrote:
>> @@ -557,7 +557,7 @@ static int __io_timeout_prep(struct io_kiocb *req,
>> data->req = req;
>> data->flags = flags;
>>
>> - if (get_timespec64(&data->ts, u64_to_user_ptr(sqe->addr)))
>> + if (get_timespec64(&data->ts, u64_to_user_ptr(READ_ONCE(sqe->addr))))
>> return -EFAULT;
>
> Should io_timeout_remove_prep() get the same update? Otherwise looks
> good.
Yep looks like. Just went hunting if we missed this in other spots,
and only other one I can find is in io_uring_cmd_getsockname().
--
Jens Axboe
next prev parent reply other threads:[~2026-02-24 18:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 16:12 [PATCH 0/2] timeout immediate arg Pavel Begunkov
2026-02-24 16:12 ` [PATCH 1/2] io_uring/timeout: READ_ONCE sqe->addr Pavel Begunkov
2026-02-24 16:47 ` Keith Busch
2026-02-24 18:28 ` Jens Axboe [this message]
2026-02-25 10:35 ` Pavel Begunkov
2026-02-24 16:12 ` [PATCH 2/2] io_uring/timeout: immediate timeout arg Pavel Begunkov
2026-02-24 18:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aec1803-e148-47f5-bc18-c88e8cc96123@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.