From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 757F6C4332F for ; Fri, 3 Nov 2023 15:24:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 84FA4822; Fri, 3 Nov 2023 16:23:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 84FA4822 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699025081; bh=wcKqp6aArmNcCYn8hLe9W+8wHLGk+Okob0DDUItHYu4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=hgbWYNTR2ewUZeLtNRa4q/7F4zb63atR8bCUayeCZxycc6qAm7va+ok7xN6oooZFE epLF6MNC1vY7HsYYu3cU/oZ5gMtr43rzgFjA1DeHUk97RDuczc5+xoXWmyhtClZ9rw aWakxxmREo/yU9z3xVXjhpGj8qfgEVQ3/XDucXbQ= Received: by alsa1.perex.cz (Postfix, from userid 50401) id E79E3F8055A; Fri, 3 Nov 2023 16:23:50 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 9F487F80290; Fri, 3 Nov 2023 16:23:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2592BF80290; Fri, 3 Nov 2023 16:23:47 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id 1B3D0F8003C for ; Fri, 3 Nov 2023 16:23:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1B3D0F8003C Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6AECC2F4; Fri, 3 Nov 2023 08:24:20 -0700 (PDT) Received: from [10.57.81.32] (unknown [10.57.81.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6FC03F64C; Fri, 3 Nov 2023 08:23:31 -0700 (PDT) Message-ID: <3b4ac48b-e29d-415f-89f1-6d354f18c4a4@arm.com> Date: Fri, 3 Nov 2023 15:23:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64 Content-Language: en-GB To: Mark Brown , =?UTF-8?Q?Duje_Mihanovi=C4=87?= Cc: Michael Turquette , Stephen Boyd , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tony Lindgren , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Leo Yan , Zhangfei Gao , Lubomir Rintel , Catalin Marinas , Will Deacon , Kees Cook , Tony Luck , "Guilherme G . Piccoli" , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, alsa-devel@alsa-project.org, linux-hardening@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Karel Balej , kernel test robot References: <20231102152033.5511-1-duje.mihanovic@skole.hr> From: Robin Murphy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Message-ID-Hash: XYRKQ5WC55BLK2Z2TC33ICFA5W7YZU4K X-Message-ID-Hash: XYRKQ5WC55BLK2Z2TC33ICFA5W7YZU4K X-MailFrom: robin.murphy@arm.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2023-11-02 3:26 pm, Mark Brown wrote: > On Thu, Nov 02, 2023 at 04:20:29PM +0100, Duje Mihanović wrote: >> The SSPA driver currently seems to generate ARM32 assembly, which causes >> build errors when building a kernel for an ARM64 ARCH_MMP platform. >> >> Fixes: fa375d42f0e5 ("ASoC: mmp: add sspa support") >> Reported-by: kernel test robot > >> tristate "SoC Audio via MMP SSPA ports" >> - depends on ARCH_MMP >> + depends on ARCH_MMP && ARM > > This isn't a fix for the existing code, AFAICT the issue here is that > ARCH_MMP is currently only available for arm and presumably something in > the rest of your series makes it available for arm64. This would be a > prerequisite for that patch. > > Please don't just insert random fixes tags just because you can. FWIW it doesn't even seem to be the right reason either. AFACIT the issue being introduced is that SND_MMP_SOC_SSPA selects SND_ARM which depends on ARM, but after patch #8 ARCH_MMP itself will no longer necessarily imply ARM. The fact that selecting SND_ARM with unmet dependencies also allows SND_ARMAACI to be enabled (which appears to be the only thing actually containing open-coded Arm asm) is tangential. Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CA4DC4332F for ; Fri, 3 Nov 2023 15:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EuQW6SQLIMpCWseC0vIYyA+sUuIDBRor7IWNbKJY7AQ=; b=ikuzZdXWhzUFqV zTXlwd0LuH8X5QoEGI7tWJg5So6AiTOq6VkycKEWwFGB04wKNDKsAoyBRqroJEkEJMG9lF1eX++fu k7aKnKmSR6cWe+3NdasHLrV1rNuIpsBJm9cF5g5WNjBUhoHG79Vdsp+JwZ7aeuporcol5nsmpn/Ex 7TL3VGDznFSQH4DsSMQ8eoWrmp/mYuH6GJbkmtgUpuDKXJKxqjo+RTDe9zmgp0ADqnREv52tf75QH gfn7JVu4mMYHA1DmXwA86lRhLQmFEplewWV6x+2g+BwO5e/fI0wL9rcnvI1glWouteUXwbCxuURwK 4UpehGUdRIzl8NfGRp+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyw1T-00BgEv-0w; Fri, 03 Nov 2023 15:23:47 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyw1Q-00BgDo-2h for linux-arm-kernel@lists.infradead.org; Fri, 03 Nov 2023 15:23:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6AECC2F4; Fri, 3 Nov 2023 08:24:20 -0700 (PDT) Received: from [10.57.81.32] (unknown [10.57.81.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A6FC03F64C; Fri, 3 Nov 2023 08:23:31 -0700 (PDT) Message-ID: <3b4ac48b-e29d-415f-89f1-6d354f18c4a4@arm.com> Date: Fri, 3 Nov 2023 15:23:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 06/10] ASoC: pxa: Suppress SSPA on ARM64 Content-Language: en-GB To: Mark Brown , =?UTF-8?Q?Duje_Mihanovi=C4=87?= Cc: Michael Turquette , Stephen Boyd , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tony Lindgren , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Leo Yan , Zhangfei Gao , Lubomir Rintel , Catalin Marinas , Will Deacon , Kees Cook , Tony Luck , "Guilherme G . Piccoli" , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, alsa-devel@alsa-project.org, linux-hardening@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Karel Balej , kernel test robot References: <20231102152033.5511-1-duje.mihanovic@skole.hr> From: Robin Murphy In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231103_082344_942070_55D44859 X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMy0xMS0wMiAzOjI2IHBtLCBNYXJrIEJyb3duIHdyb3RlOgo+IE9uIFRodSwgTm92IDAy LCAyMDIzIGF0IDA0OjIwOjI5UE0gKzAxMDAsIER1amUgTWloYW5vdmnEhyB3cm90ZToKPj4gVGhl IFNTUEEgZHJpdmVyIGN1cnJlbnRseSBzZWVtcyB0byBnZW5lcmF0ZSBBUk0zMiBhc3NlbWJseSwg d2hpY2ggY2F1c2VzCj4+IGJ1aWxkIGVycm9ycyB3aGVuIGJ1aWxkaW5nIGEga2VybmVsIGZvciBh biBBUk02NCBBUkNIX01NUCBwbGF0Zm9ybS4KPj4KPj4gRml4ZXM6IGZhMzc1ZDQyZjBlNSAoIkFT b0M6IG1tcDogYWRkIHNzcGEgc3VwcG9ydCIpCj4+IFJlcG9ydGVkLWJ5OiBrZXJuZWwgdGVzdCBy b2JvdCA8bGtwQGludGVsLmNvbT4KPiAKPj4gICAJdHJpc3RhdGUgIlNvQyBBdWRpbyB2aWEgTU1Q IFNTUEEgcG9ydHMiCj4+IC0JZGVwZW5kcyBvbiBBUkNIX01NUAo+PiArCWRlcGVuZHMgb24gQVJD SF9NTVAgJiYgQVJNCj4gCj4gVGhpcyBpc24ndCBhIGZpeCBmb3IgdGhlIGV4aXN0aW5nIGNvZGUs IEFGQUlDVCB0aGUgaXNzdWUgaGVyZSBpcyB0aGF0Cj4gQVJDSF9NTVAgaXMgY3VycmVudGx5IG9u bHkgYXZhaWxhYmxlIGZvciBhcm0gYW5kIHByZXN1bWFibHkgc29tZXRoaW5nIGluCj4gdGhlIHJl c3Qgb2YgeW91ciBzZXJpZXMgbWFrZXMgaXQgYXZhaWxhYmxlIGZvciBhcm02NC4gIFRoaXMgd291 bGQgYmUgYQo+IHByZXJlcXVpc2l0ZSBmb3IgdGhhdCBwYXRjaC4KPiAKPiBQbGVhc2UgZG9uJ3Qg anVzdCBpbnNlcnQgcmFuZG9tIGZpeGVzIHRhZ3MganVzdCBiZWNhdXNlIHlvdSBjYW4uCgpGV0lX IGl0IGRvZXNuJ3QgZXZlbiBzZWVtIHRvIGJlIHRoZSByaWdodCByZWFzb24gZWl0aGVyLiBBRkFD SVQgdGhlIAppc3N1ZSBiZWluZyBpbnRyb2R1Y2VkIGlzIHRoYXQgU05EX01NUF9TT0NfU1NQQSBz ZWxlY3RzIFNORF9BUk0gd2hpY2ggCmRlcGVuZHMgb24gQVJNLCBidXQgYWZ0ZXIgcGF0Y2ggIzgg QVJDSF9NTVAgaXRzZWxmIHdpbGwgbm8gbG9uZ2VyIApuZWNlc3NhcmlseSBpbXBseSBBUk0uIFRo ZSBmYWN0IHRoYXQgc2VsZWN0aW5nIFNORF9BUk0gd2l0aCB1bm1ldCAKZGVwZW5kZW5jaWVzIGFs c28gYWxsb3dzIFNORF9BUk1BQUNJIHRvIGJlIGVuYWJsZWQgKHdoaWNoIGFwcGVhcnMgdG8gYmUg CnRoZSBvbmx5IHRoaW5nIGFjdHVhbGx5IGNvbnRhaW5pbmcgb3Blbi1jb2RlZCBBcm0gYXNtKSBp cyB0YW5nZW50aWFsLgoKUm9iaW4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==