From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hugo Karlsson <huggek@klattorp.se>, sre@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
matheus@castello.eng.br, me@iskren.info,
m.szyprowski@samsung.com, clamor95@gmail.com
Subject: Re: [RESEND PATCH 1/3] power: supply: max17040: pass the device fwnode to the power supply core
Date: Mon, 9 Nov 2026 08:30:44 +0100 [thread overview]
Message-ID: <3b4d9f8a-2b5b-49c6-a2fa-666548029975@kernel.org> (raw)
In-Reply-To: <20261108154241.198160-2-huggek@klattorp.se>
On 08/11/2026 16:42, Hugo Karlsson wrote:
> Since commit f4b782af61ae ("power: max17040: pass status property from
> supplier") the driver forwards POWER_SUPPLY_PROP_STATUS to its supplier,
> and the DT binding documents a power-supplies property for naming that
> supplier. The driver never passes its device node to
> devm_power_supply_register(), however, so the power supply core cannot
> parse power-supplies and the battery never gets a supplier from
> firmware. The status lookup then always returns -ENODEV and userspace
> sees POWER_SUPPLY_STATUS_UNKNOWN.
>
> Set psy_cfg.fwnode the way max17042_battery and cw2015_battery already
> do.
>
> Fixes: f4b782af61ae ("power: max17040: pass status property from supplier")
> Assisted-by: Claude:claude-opus-5-5 [Claude Code]
If you are resending, then at least you could run checkpatch.
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-09 7:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 15:42 [RESEND PATCH 0/3] power: supply: max17040: report charging status from a gpio-charger Hugo Karlsson
2026-11-08 15:42 ` [RESEND PATCH 1/3] power: supply: max17040: pass the device fwnode to the power supply core Hugo Karlsson
2026-11-08 16:15 ` Svyatoslav Ryhel
2026-11-09 7:30 ` Krzysztof Kozlowski [this message]
2026-11-09 8:53 ` Hugo Karlsson
2026-11-09 10:06 ` Krzysztof Kozlowski
2026-11-08 15:42 ` [RESEND PATCH 2/3] power: supply: max17040: derive status from an online supplier Hugo Karlsson
2026-11-08 15:42 ` [RESEND PATCH 3/3] power: supply: max17040: clamp the reported capacity to 100 % Hugo Karlsson
2026-11-08 16:24 ` Svyatoslav Ryhel
2026-11-09 1:23 ` [RESEND PATCH 0/3] power: supply: max17040: report charging status from a gpio-charger Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b4d9f8a-2b5b-49c6-a2fa-666548029975@kernel.org \
--to=krzk@kernel.org \
--cc=clamor95@gmail.com \
--cc=huggek@klattorp.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matheus@castello.eng.br \
--cc=me@iskren.info \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.