From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E855C433F5 for ; Mon, 14 Feb 2022 18:10:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357345AbiBNSK0 (ORCPT ); Mon, 14 Feb 2022 13:10:26 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357344AbiBNSKX (ORCPT ); Mon, 14 Feb 2022 13:10:23 -0500 X-Greylist: delayed 396 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 14 Feb 2022 10:10:12 PST Received: from mx2.securetransport.de (mx2.securetransport.de [IPv6:2a03:4000:13:6c7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BBAFD65171; Mon, 14 Feb 2022 10:10:12 -0800 (PST) Received: from mail.dh-electronics.com (business-24-134-97-169.pool2.vodafone-ip.de [24.134.97.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.securetransport.de (Postfix) with ESMTPSA id 4AC115E9CC; Mon, 14 Feb 2022 19:02:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1644861768; bh=7xfalOX+rWD4NJI43BSDKMhWEeNFDqerF9Kf3/7C4RA=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=to8ggP9eD3YNDZScXwrMAoJ7D0rCUx1aVHHAh3B9mPByEN5yhJEqPTFVETJyfcnnz 0mKctBGU5R8Uf0M1uhF41UrMnyS33+YwJc8LFzP6QH0z3qT49pa7uS2R4ATLLSbXZ9 Zuzxas0DAE+PvKCP3oERtK+zmlIkhiOaTYd9mel4bLbOm2S4gq16Tb3KqWurWSm8nJ 1lwEvrzorM2VEFjZYEGlToZuoYWyKhMq65nZ/9RB7X57C2UqobSEdpxJH1Pnk2MFc9 6oJ+DOJKoijgjKD8myR8rq8DIvAyshpgphOXBCkhrCZIpnQdwtMzd7SbVEysn0KACW HT822K2+UqA4Q== Received: from DHPWEX01.DH-ELECTRONICS.ORG (10.64.2.30) by DHPWEX01.DH-ELECTRONICS.ORG (10.64.2.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Mon, 14 Feb 2022 19:02:42 +0100 Received: from DHPWEX01.DH-ELECTRONICS.ORG ([fe80::6ced:fa7f:9a9c:e579]) by DHPWEX01.DH-ELECTRONICS.ORG ([fe80::6ced:fa7f:9a9c:e579%6]) with mapi id 15.02.0986.015; Mon, 14 Feb 2022 19:02:42 +0100 From: Christoph Niedermaier To: Christoph Niedermaier , Guenter Roeck , Adam Thomson , Andrej Picej , "linux-arm-kernel@lists.infradead.org" CC: Support Opensource , Wim Van Sebroeck , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [RFC PATCH] watchdog: da9062: Correct the timeout values [Klartext] Thread-Topic: [RFC PATCH] watchdog: da9062: Correct the timeout values [Klartext] Thread-Index: AdfwANztWgHN3oJ0TZqwlPeCV8dlmAAIEJYAAALaKlAAD68ZMAxWZv9g Date: Mon, 14 Feb 2022 18:02:42 +0000 Message-ID: <3bb120e2fcb649f09cf0f8c881f442ff@dh-electronics.com> References: <4254747d8cde4c5dbcbfdd00a3ecf701@dh-electronics.com> <03871bd3-ea78-52e1-f57b-3e35724c8934@roeck-us.net> In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.51.18] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org RnJvbTogbGludXgtYXJtLWtlcm5lbCBbbWFpbHRvOmxpbnV4LWFybS1rZXJuZWwtYm91bmNlc0Bs aXN0cy5pbmZyYWRlYWQub3JnXQ0KU2VudDogTW9uZGF5LCBEZWNlbWJlciAxMywgMjAyMSAxMTo0 NSBQTQ0KPj4+Pj4+IFRoYW5rcyBhbnl3YXksIHNvIG5vdyBJIGtub3cgaXQgbXVzdCBiZQ0KPj4+ Pj4+IHByb2JsZW0gd2l0aCBteSBEQTkwNjEgY2hpcC4NCj4+Pj4+Pg0KPj4+Pj4+IEBBZGFtDQo+ Pj4+Pj4gV2hlcmUgY2FuIGl0IGNvbWUgZnJvbT8NCj4+Pj4+PiBDYW4geW91IGdpdmUgd2UgYSBo aW50IHdoYXQgdG8gY2hlY2s/DQo+Pj4+Pg0KPj4+Pj4gSSd2ZSBzcG9rZW4gaW50ZXJuYWxseSBh bmQgaGF2ZSBiZWVuIGluZm9ybWVkIHRoYXQgdGhpcyBpcyBkb3duIHRvIHRoZSBmYWN0IHRoYXQN Cj4+Pj4+IERBOTA2MSBydW5zIG9ubHkgZnJvbSBhbiBpbnRlcm5hbCBvc2NpbGxhdG9yIHdoaWNo IG1heSBiZSBzbG93ZXIuIFRoZSBpbmRpY2F0aW9uDQo+Pj4+PiBpcyB0aGF0IHRoZSB2YWx1ZXMg Zm9yIFRXRFNDQUxFIGRlc2NyaWJlIHRoZSB3aW5kb3cgd2hlcmUgaWYgYSBraWNrL3Bpbmcgb2Nj dXJzDQo+Pj4+PiB3aXRoaW4gdGhhdCBwZXJpb2QgdGhlbiB0aGUgd2F0Y2hkb2cgaXMgZ3VhcmFu dGVlZCAqbm90KiB0byB0aW1lb3V0LiBUaGUgYWN0dWFsDQo+Pj4+PiB0aW1lb3V0IHdvdWxkIGJl IGF0IHNvbWUgcG9pbnQgYWZ0ZXIgdGhlIHNlbGVjdGVkIHRpbWVvdXQgcGVyaW9kLCBhc3N1bWlu ZyBubw0KPj4+Pj4gcGluZy9raWNrIG9jY3VycmVkLg0KPj4+Pj4NCj4+Pj4+IFRhYmxlIDggaW4g dGhlIGRhdGFzaGVldCBzcGVjaWZpZXMgYSBtaW5pbXVtIHdhdGNoZG9nIHRpbWVvdXQgb2YgMi41 cyAodFdETUFYKQ0KPj4+Pj4gdW5kZXIgc3BlY2lmaWMgb3BlcmF0aW5nIGNvbmRpdGlvbnMsIHNv IGlmIHRoZSBtaW5pbXVtIDJzIHdpbmRvdyB3YXMgY2hvc2VuDQo+Pj4+PiAoVFdEU0NBTEUgPSAx KSB0aGVuIGVhcmxpZXN0IHRoZSB3YXRjaGRvZyB3b3VsZCBhY3R1YWxseSB0aW1lb3V0LCBmb2xs b3dpbmcgYQ0KPj4+Pj4gcGluZywgaXMgMi41cywgYXNzdW1pbmcgdGhlIGNvbmRpdGlvbnMgbWF0 Y2hlZCB0aG9zZSBkZXNjcmliZWQuDQo+Pj4+Pg0KPj4+Pj4gSWYgeW91IGhhdmUgZnVydGhlciBx dWVzdGlvbnMgaXQgcHJvYmFibHkgbWFrZXMgc2Vuc2UgdG8gY29udGFjdCBEaWFsb2cvUmVuZXNh cw0KPj4+Pj4gc3VwcG9ydCBhcyB0aGV5IHdpbGwgYmUgYWJsZSB0byBwcm92aWRlIG1vcmUgZGV0 YWlsZWQgaW5mbyBvbiB0aGlzLg0KPj4+Pg0KPj4+PiBTbyBhIERBOTA2MSBydW5zIG9ubHkgZnJv bSBhbiBpbnRlcm5hbCBvc2NpbGxhdG9yLCB3aGVyZWFzIGEgREE5MDYyDQo+Pj4+IGNhbiBydW4g b24gZWl0aGVyIGFuIGludGVybmFsIG9yIGFuIGV4dGVybmFsIG9zY2lsbGF0b3IuIFNvIHRoaXMN Cj4+Pj4gbWVhbnMgdGhhdCB0aGUgREE5MDYxIHRpbWVvdXQgdmFsdWVzIGFyZSBkaWZmZXIgZnJv bSB0aGUgREE5MDYyDQo+Pj4+IHdpdGggYW4gZXh0ZXJuYWwgb3NjaWxsYXRvciBub3Qgb25seSBv biBteSBkZXZpY2UgYnV0IG9uIGFsbCBEQTkwNjENCj4+Pj4gZGV2aWNlcy4NCj4+Pj4NCj4+Pj4g VGhpcyBhcmUgdGhlIHZhbHVlcyAoaW4gc2Vjb25kcykgaW4gY29tcGFyaXNvbjoNCj4+Pj4gREE5 MDYyIChmcm9tIGRyaXZlcik6IDAgIDIgIDQgICA4ICAxNiAgMzIgIDY1IDEzMQ0KPj4+PiBEQTkw NjEgKG1lYXN1cmVkKTogICAgMCAgMyAgNiAgMTIgIDI1ICA1MSAxMDIgMjA0DQo+Pj4+ID09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCj4+Pj4gRGlmZmVy ZW5jZTogICAgICAgICAgIDAgKzEgKzIgICs0ICArOSArMTkgKzM3ICs3Mw0KPj4+Pg0KPj4+PiBJ biBteSBvcGluaW9uLCB0aGUgZGlmZmVyZW5jZXMgaW4gdGhlIGhpZ2hlciB2YWx1ZXMgYXJlIHZl cnkgaHVnZS4NCj4+Pj4gSWYgSSBleHBlY3QgdGhhdCB0aGUgd2F0Y2hkb2cgdHJpZ2dlcnMgYW5k IEkgaGF2ZSB0byB3YWl0IG1vcmUgdGhhbg0KPj4+PiBhIG1pbnV0ZSBmb3IgdGhhdCB0byBoYXBw ZW4gSSBhc2sgbXlzZWxmIGlzIHRoZXJlIHNvbWV0aGluZyB3cm9uZy4NCj4+Pj4NCj4+Pj4gQEFu ZHJlag0KPj4+PiBJIGd1ZXNzLCB5b3UgYXJlIHVzaW5nIGFuIGV4dGVybmFsIG9zY2lsbGF0b3Is IGFyZW4ndCB5b3U/DQo+Pj4+DQo+Pj4+IEBBZGFtDQo+Pj4+IElzIHRoZXJlIGEgd2F5IHRvIGNo ZWNrIGluIHRoZSBkcml2ZXIgd2hpY2ggb3NjaWxsYXRvciBpcyBpbiB1c2U/DQo+Pj4+DQo+Pj4+ IEBNYWludGFpbmVycw0KPj4+PiBJcyBpbiB0aGUgZHJpdmVyIGEgbmVlZCB0byBkaXN0aW5ndWlz aCBiZXR3ZWVuIGFuIGV4dGVybmFsIGFuZCBhbg0KPj4+PiBpbnRlcm5hbCBvc2NpbGxhdG9yIHRv IGdldCB0aGUgdGltZW91dCB2YWx1ZXMgbW9yZSBhY2N1cmF0ZT8NCj4+Pj4NCj4+Pg0KPj4+IEl0 IHdvdWxkIGJlIHZlcnkgZGVzaXJhYmxlIHRvIGdldCB0aW1lb3V0IHZhbHVlcyBtb3JlIGFjY3Vy YXRlLg0KPj4+IEkgd291bGQgbm90IHdhbnQgdG8gZGljdGF0ZSBob3cgdG8gaW1wbGVtZW50IGl0 LCB0aG91Z2guDQo+Pj4gSXQgY291bGQgYmUgYXV0b21hdGljYWxseSBkZXRlY3RlZCBpZiB0aGF0 IGlzIHBvc3NpYmxlLCB0aGVyZQ0KPj4+IGNvdWxkIGJlIGEgZGV2aWNldHJlZSBjbG9jayBwcm9w ZXJ0eSBwcm92aWRpbmcgdGhlIGNsb2NrDQo+Pj4gZnJlcXVlbmN5LCBvciBtYXliZSB0aGVyZSBp cyBzb21lIG90aGVyIHNvbHV0aW9uLg0KPj4+DQo+Pj4gR3VlbnRlcg0KPj4NCj4+IEkgYW0gb3Bl biBmb3IgYSBnb29kIHNvbHV0aW9uLg0KPj4gTWVhbndoaWxlIEkgbWVhc3VyZWQgdGhlIHRpbWVv dXQgdmFsdWVzIG9mIG15IDggYXZhaWxhYmxlIERBOTA2MQ0KPj4gd2F0Y2hkb2dzLiBJIGRlcml2 ZWQgdGhlIGZvbGxvd2luZyBmb3JtdWxhIGZyb20gdGhlIGdpdmVuIGZvcm11bGENCj4+IGF0IHRo ZSBkYXRhIHNoZWV0IGFuZCB0aGUgY2xvY2sgZGl2aWRlciBvZiAyXjE2Og0KPj4NCj4+IGYgPSAy XigxNStUV0RTQ0FMRSkgLyB0DQo+Pg0KPj4gRm9ybXVsYSBjaGVjayB3aXRoIHRoZSBleHRlcm5h bCBvc2NpbGxhdG9yICgzMmtIeikgVFdEU0NBTEU9NyBAIDEzMXM6DQo+PiBmID0gMl4oMTUrNykg LyAxMzEgPSAzMjAxN0h6ICg9PiBzaG91bGQgYmUgT0spDQo+Pg0KPj4gVGhlIHRpbWVvdXRzIG9m IG15IDggd2F0Y2hkb2dzICg5MDYxLUFBKSB3aXRoIFRXRFNDQUxFPTc6DQo+PiB0NyA9IDIxMXMg PT4gMTk4NzhIeg0KPj4gdDcgPSAxOTdzID0+IDIxMjkxSHoNCj4+IHQ3ID0gMjAzcyA9PiAyMDY2 Mkh6DQo+PiB0NyA9IDIwNHMgPT4gMjA1NjBIeg0KPj4gdDcgPSAyMDZzID0+IDIwMzYxSHoNCj4+ IHQ3ID0gMTk4cyA9PiAyMTY2Mkh6DQo+PiB0NyA9IDIwMHMgPT4gMjA5NzJIeg0KPj4NCj4+IEFj Y29yZGluZyB0byB0aGUgZGF0YSBzaGVldCB0aGUgaW50ZXJuYWwgb3NjaWxsYXRvciBzaG91bGQg cnVuIGF0IDI1a0h6Lg0KPj4gVGhlIGF2ZXJhZ2UgZnJlcXVlbmN5IG9mIG15IDggZGV2aWNlcyBp cyAyMC42a0h6LiBNYXliZSB0aGUgZGF0YSBzaGVldA0KPj4gQ2xvY2sgdmFsdWUgaXMgYSBtYXgg dmFsdWUuIFRoZSB0aW1lb3V0IGRpZmZlcmVuY2Ugb24gbXkgOCBkZXZpY2VzIGFyZQ0KPj4gMTRz LiBTbyB0aGUgdmFsdWVzIHZhcnkgZnJvbSBkZXZpY2UgdG8gZGV2aWNlLCBhbmQgbWF5YmUgdGhl cmUgaXMgYWxzbyBhDQo+PiB0ZW1wZXJhdHVyZSBjb21wb25lbnQuDQo+Pg0KPj4gQEFkYW0NCj4+ IElzIHRoZXJlIGEgd2F5IHRvIGNoZWNrIHdoaWNoIG9zY2lsbGF0b3IgaXMgaW4gdXNlPw0KPj4g SXMgdGhlcmUgYSB3YXkgdG8gZmluZCB0aGUgY3VycmVudCBvc2NpbGxhdG9yIGZyZXF1ZW5jeT8N Cj4+IEFyZSB0aGVyZSBhbnkgb3RoZXIgaWRlYXMvc29sdXRpb25zIHRvIGdldCB0aGUgdGltZW91 dCB2YWx1ZXMgbW9yZSBhY2N1cmF0ZT8NCj4gDQo+IEFzIEkgc2VudCBteSBFLU1haWwgSSBkaWRu J3Qgc2VlIHlvdXIgYW5zd2VyLCBzbyBoZXJlIGl0IGlzOg0KPiANCj4+IEEgcXVpY2sgc2NhbiBv ZiB0aGUgREE5MDYyIGRhdGFzaGVldCBzaG93cyB0aGF0IHJlZy9maWVsZCBFTl8zMksvQ1JZU1RB TCB3aWxsDQo+PiBpbmRpY2F0ZSB0aGUgcHJlc2VuY2Ugb2YgYSAzMktIeiBjcnlzdGFsIG9zY2ls bGF0b3IuIE9idmlvdXNseSBvbiBEQTkwNjEgdGhhdA0KPj4gb3B0aW9uIGlzbid0IGF2YWlsYWJs ZS4NCj4+DQo+PiBJIHRoaW5rIHRoZSBwcm9ibGVtIHNlZW1zIHRvIGxpZSBhcm91bmQgZGV0ZXJt aW5pbmcgdGhlIGludGVybmFsIG9zY2lsbGF0b3Incw0KPj4gZnJlcXVlbmN5LiBEYXRhc2hlZXQg cmVmZXJlbmNlcyAyNU1oeiBpbiBUYWJsZSA5IChXYXRjaGRvZyBFbGVjdHJpY2FsDQo+PiBDaGFy YWN0ZXJpc3RpY3MpLCBidXQgdGhhdCBkb2Vzbid0IHNlZW0gdG8gdGFsbHkgd2l0aCB5b3VyIHRp bWluZ3MgYW5kIEkgZG9uJ3QNCj4+IHNlZSBhbiBvYnZpb3VzIHdheSBpbiB0aGUgcmVnbWFwIHRv IGNhbGN1bGF0ZSB0aGlzIGF0IHJ1biB0aW1lLiAqSWYqIHRoZQ0KPj4gb3NjaWxsYXRvciBmcmVx dWVuY3kgdmFyaWVzIGZyb20gcGFydCB0byBwYXJ0LCBvciB1bmRlciBkaWZmZXJlbnQgZW52aXJv bm1lbnRhbA0KPj4gY29uZGl0aW9ucywgdGhlbiBpdCdzIGdvaW5nIHRvIGJlIHRvdWdoIHRvIHRp ZSB0aGlzIGRvd24sIGFuZCB5b3Ugd291bGRuJ3Qgd2FudA0KPj4gdG8gc3RhdGUgYSB0aW1lb3V0 IHZhbHVlIHRoYXQncyBsb25nZXIgdGhhbiByZWFsaXR5Lg0KPiANCj4gQEFkYW0NCj4gV2hhdCBk byB5b3UgdGhpbmsgaWYgSSBhZGQgYWxzbyB0aGUgdGltZW91dCB2YWx1ZXMgZm9yIHRoZSBpbnRl cm5hbA0KPiBvc2NpbGxhdG9yPw0KPiBUaGFuIHRoZSB2YWx1ZXMgd291bGQgYmU6DQo+IA0KPiB0 ID0gMl4oMTUrVFdEU0NBTEUpIC8gZg0KPiANCj4gSW50ZXJuYWwgMjVrSHogb3NjaWxsYXRvcjog MCAgMiAgNSAgMTAgIDIwICA0MSAgODMgMTY3DQo+IA0KPiBJbiBjb21wYXJpc29uIHRvIHRoZQ0K PiBleHRlcm5hbCAzMmtIeiBvc2NpbGxhdG9yOiAwICAyICA0ICAgOCAgMTYgIDMyICA2NSAxMzEN Cj4gDQo+IFNvIHRoZSBkaWZmZXJlbmNlIHRvIG15IG1lYXN1cmVkIHZhbHVlcyB3aWxsIGRlY3Jl YXNlIGFuZCBpdCB3aWxsIGltcHJvdmUNCj4gdGhlDQo+IGN1cnJlbnQgZHJpdmVyIHRvd2FyZHMg bW9yZSBhY2N1cmF0ZSB2YWx1ZXMuDQo+IA0KPiBCdHcgaWYgSSBjYWxjdWxhdGUgdGhlIHZhbHVl cyB3aXRoIDMyNzY4SHogKHRoZSB0eXBpY2FsIDMya0h6IG9zY2lsbGF0b3IpLCBJDQo+IGdldCB0 aGUNCj4gZm9sbG93aW5nIHZhbHVlczoNCj4gMzI3NjhIeiBvc2NpbGxhdG9yOiAgICAgICAgMCAg MiAgNCAgIDggIDE2ICAzMiAgNjQgMTI4DQoNCkkgY29tZSB0byB0aGUgY29uY2x1c2lvbiB0aGF0 IHVuZGVyIG5vcm1hbCBjb25kaXRpb24gKHJvb20gdGVtcGVyYXR1cmUpIHRoZQ0KdGltZW91dCB2 YWx1ZXMgY291bGQgYmUgaW1wcm92ZWQsIGJ1dCBkdWUgdG8gdGhlIHVzZWQgaW50ZXJuYWwgcmlu ZyBvc2NpbGxhdG9yDQpvbiB0aGUgREE5MDYxIGNoaXAgdW5kZXIgZXh0cmVtZSBjb25kaXRpb25z IGxpa2UgYXV0b21vdGl2ZSAoMTI1IGRlZ3JlZXMpIHRoZQ0KdmFsdWVzIGNvbWUgY2xvc2UgdG8g dGhlIERBOTA2MiB0aW1lb3V0IHZhbHVlcywgaWYgYW4gZXh0ZXJuYWwgb3NjaWxsYXRvcg0KaXMg dXNlZC4gSW4gb3JkZXIgbm90IHRvIHRyaWdnZXIgdG9vIGVhcmx5IGluIGV4dHJlbWUgc2l0dWF0 aW9ucywgdGhlIHZhbHVlcw0KbXVzdCBiZSBsZWZ0IGFzIHRoZXkgYXJlLiBCdXQgSSB0b2xkIERp YWxvZyB0byBhZGQgYSBub3RlIGluIHRoZSBkYXRhIHNoZWV0DQpleHBsYWluaW5nIHRoZSBkZXZp YXRpb24gd2hlbiB0aGUgaW50ZXJuYWwgb3NjaWxsYXRvciBpcyB1c2VkIChEQTkwNjEpLg0KDQpU aGFua3MgZm9yIGhlbHBpbmcgbWUgYW5kIGJlc3QgcmVnYXJkcw0KQ2hyaXN0b3BoDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73E08C433EF for ; Mon, 14 Feb 2022 18:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DoDOoKgv1KOIEtQtW3ubVZjsa0stB39zvNxfVui+3EI=; b=KzLL+TUJSwtKXq +gXJNP3Qdbem8xf9EXQRwVtS+85LAq6WLlTkmMF+tVpgVu0rAMQhFG7Y1dp9Ozb+H4MGoHwfx3XRf 9jLBpJ6zW25Fy+JVUrPNPV6PN8boFxcTn0GQIDwRDl0GSs2GB0pmYGvwLfcGWkeStNGsft32kVR6i fSZ+ilud8XYidbxUg1zDx2/envEPo8Yd4MdsdqJNWd/wEskYtOmgW2KiI7PlTyEuisxAJ9YjTaVAR gu10qaX3568DcC9p52dUIpPeWfK8l/Rzie6bJbZuOnqb2+b1WaGclcj14xfqc3qi8bCD2ug7kHtud K39TOn26GlvYcXr/0HTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJfgp-00GTDQ-Bt; Mon, 14 Feb 2022 18:03:07 +0000 Received: from mx2.securetransport.de ([188.68.39.254]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJfgl-00GTCk-O4 for linux-arm-kernel@lists.infradead.org; Mon, 14 Feb 2022 18:03:05 +0000 Received: from mail.dh-electronics.com (business-24-134-97-169.pool2.vodafone-ip.de [24.134.97.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.securetransport.de (Postfix) with ESMTPSA id 4AC115E9CC; Mon, 14 Feb 2022 19:02:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1644861768; bh=7xfalOX+rWD4NJI43BSDKMhWEeNFDqerF9Kf3/7C4RA=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=to8ggP9eD3YNDZScXwrMAoJ7D0rCUx1aVHHAh3B9mPByEN5yhJEqPTFVETJyfcnnz 0mKctBGU5R8Uf0M1uhF41UrMnyS33+YwJc8LFzP6QH0z3qT49pa7uS2R4ATLLSbXZ9 Zuzxas0DAE+PvKCP3oERtK+zmlIkhiOaTYd9mel4bLbOm2S4gq16Tb3KqWurWSm8nJ 1lwEvrzorM2VEFjZYEGlToZuoYWyKhMq65nZ/9RB7X57C2UqobSEdpxJH1Pnk2MFc9 6oJ+DOJKoijgjKD8myR8rq8DIvAyshpgphOXBCkhrCZIpnQdwtMzd7SbVEysn0KACW HT822K2+UqA4Q== Received: from DHPWEX01.DH-ELECTRONICS.ORG (10.64.2.30) by DHPWEX01.DH-ELECTRONICS.ORG (10.64.2.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Mon, 14 Feb 2022 19:02:42 +0100 Received: from DHPWEX01.DH-ELECTRONICS.ORG ([fe80::6ced:fa7f:9a9c:e579]) by DHPWEX01.DH-ELECTRONICS.ORG ([fe80::6ced:fa7f:9a9c:e579%6]) with mapi id 15.02.0986.015; Mon, 14 Feb 2022 19:02:42 +0100 From: Christoph Niedermaier To: Christoph Niedermaier , Guenter Roeck , Adam Thomson , Andrej Picej , "linux-arm-kernel@lists.infradead.org" CC: Support Opensource , Wim Van Sebroeck , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [RFC PATCH] watchdog: da9062: Correct the timeout values [Klartext] Thread-Topic: [RFC PATCH] watchdog: da9062: Correct the timeout values [Klartext] Thread-Index: AdfwANztWgHN3oJ0TZqwlPeCV8dlmAAIEJYAAALaKlAAD68ZMAxWZv9g Date: Mon, 14 Feb 2022 18:02:42 +0000 Message-ID: <3bb120e2fcb649f09cf0f8c881f442ff@dh-electronics.com> References: <4254747d8cde4c5dbcbfdd00a3ecf701@dh-electronics.com> <03871bd3-ea78-52e1-f57b-3e35724c8934@roeck-us.net> In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.51.18] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220214_100304_104922_A4C5163D X-CRM114-Status: GOOD ( 40.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: linux-arm-kernel [mailto:linux-arm-kernel-bounces@lists.infradead.org] Sent: Monday, December 13, 2021 11:45 PM >>>>>> Thanks anyway, so now I know it must be >>>>>> problem with my DA9061 chip. >>>>>> >>>>>> @Adam >>>>>> Where can it come from? >>>>>> Can you give we a hint what to check? >>>>> >>>>> I've spoken internally and have been informed that this is down to the fact that >>>>> DA9061 runs only from an internal oscillator which may be slower. The indication >>>>> is that the values for TWDSCALE describe the window where if a kick/ping occurs >>>>> within that period then the watchdog is guaranteed *not* to timeout. The actual >>>>> timeout would be at some point after the selected timeout period, assuming no >>>>> ping/kick occurred. >>>>> >>>>> Table 8 in the datasheet specifies a minimum watchdog timeout of 2.5s (tWDMAX) >>>>> under specific operating conditions, so if the minimum 2s window was chosen >>>>> (TWDSCALE = 1) then earliest the watchdog would actually timeout, following a >>>>> ping, is 2.5s, assuming the conditions matched those described. >>>>> >>>>> If you have further questions it probably makes sense to contact Dialog/Renesas >>>>> support as they will be able to provide more detailed info on this. >>>> >>>> So a DA9061 runs only from an internal oscillator, whereas a DA9062 >>>> can run on either an internal or an external oscillator. So this >>>> means that the DA9061 timeout values are differ from the DA9062 >>>> with an external oscillator not only on my device but on all DA9061 >>>> devices. >>>> >>>> This are the values (in seconds) in comparison: >>>> DA9062 (from driver): 0 2 4 8 16 32 65 131 >>>> DA9061 (measured): 0 3 6 12 25 51 102 204 >>>> ================================================= >>>> Difference: 0 +1 +2 +4 +9 +19 +37 +73 >>>> >>>> In my opinion, the differences in the higher values are very huge. >>>> If I expect that the watchdog triggers and I have to wait more than >>>> a minute for that to happen I ask myself is there something wrong. >>>> >>>> @Andrej >>>> I guess, you are using an external oscillator, aren't you? >>>> >>>> @Adam >>>> Is there a way to check in the driver which oscillator is in use? >>>> >>>> @Maintainers >>>> Is in the driver a need to distinguish between an external and an >>>> internal oscillator to get the timeout values more accurate? >>>> >>> >>> It would be very desirable to get timeout values more accurate. >>> I would not want to dictate how to implement it, though. >>> It could be automatically detected if that is possible, there >>> could be a devicetree clock property providing the clock >>> frequency, or maybe there is some other solution. >>> >>> Guenter >> >> I am open for a good solution. >> Meanwhile I measured the timeout values of my 8 available DA9061 >> watchdogs. I derived the following formula from the given formula >> at the data sheet and the clock divider of 2^16: >> >> f = 2^(15+TWDSCALE) / t >> >> Formula check with the external oscillator (32kHz) TWDSCALE=7 @ 131s: >> f = 2^(15+7) / 131 = 32017Hz (=> should be OK) >> >> The timeouts of my 8 watchdogs (9061-AA) with TWDSCALE=7: >> t7 = 211s => 19878Hz >> t7 = 197s => 21291Hz >> t7 = 203s => 20662Hz >> t7 = 204s => 20560Hz >> t7 = 206s => 20361Hz >> t7 = 198s => 21662Hz >> t7 = 200s => 20972Hz >> >> According to the data sheet the internal oscillator should run at 25kHz. >> The average frequency of my 8 devices is 20.6kHz. Maybe the data sheet >> Clock value is a max value. The timeout difference on my 8 devices are >> 14s. So the values vary from device to device, and maybe there is also a >> temperature component. >> >> @Adam >> Is there a way to check which oscillator is in use? >> Is there a way to find the current oscillator frequency? >> Are there any other ideas/solutions to get the timeout values more accurate? > > As I sent my E-Mail I didn't see your answer, so here it is: > >> A quick scan of the DA9062 datasheet shows that reg/field EN_32K/CRYSTAL will >> indicate the presence of a 32KHz crystal oscillator. Obviously on DA9061 that >> option isn't available. >> >> I think the problem seems to lie around determining the internal oscillator's >> frequency. Datasheet references 25Mhz in Table 9 (Watchdog Electrical >> Characteristics), but that doesn't seem to tally with your timings and I don't >> see an obvious way in the regmap to calculate this at run time. *If* the >> oscillator frequency varies from part to part, or under different environmental >> conditions, then it's going to be tough to tie this down, and you wouldn't want >> to state a timeout value that's longer than reality. > > @Adam > What do you think if I add also the timeout values for the internal > oscillator? > Than the values would be: > > t = 2^(15+TWDSCALE) / f > > Internal 25kHz oscillator: 0 2 5 10 20 41 83 167 > > In comparison to the > external 32kHz oscillator: 0 2 4 8 16 32 65 131 > > So the difference to my measured values will decrease and it will improve > the > current driver towards more accurate values. > > Btw if I calculate the values with 32768Hz (the typical 32kHz oscillator), I > get the > following values: > 32768Hz oscillator: 0 2 4 8 16 32 64 128 I come to the conclusion that under normal condition (room temperature) the timeout values could be improved, but due to the used internal ring oscillator on the DA9061 chip under extreme conditions like automotive (125 degrees) the values come close to the DA9062 timeout values, if an external oscillator is used. In order not to trigger too early in extreme situations, the values must be left as they are. But I told Dialog to add a note in the data sheet explaining the deviation when the internal oscillator is used (DA9061). Thanks for helping me and best regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel