From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nick Li <nick.li@foursemi.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, perex@perex.cz,
tiwai@suse.com, xiaoming.yang@foursemi.com,
danyang.zheng@foursemi.com, like.xy@foxmail.com,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] ASoC: dt-bindings: Add schema for FS2104/5S audio amplifiers
Date: Thu, 10 Jul 2025 10:27:59 +0200 [thread overview]
Message-ID: <3bb34074-8ce0-4f0e-b7c7-1d77a8cd6ea3@kernel.org> (raw)
In-Reply-To: <BD2D8A14FDC941B8+aG91lowfru0KiWWW@foursemi.com>
On 10/07/2025 10:11, Nick Li wrote:
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - reset-gpios
>>> + - firmware-name
>>> + - '#sound-dai-cells'
>>
>> Keep the same order as in list of properties. OTOH, missing supplies.
>
> OK, we will fix the order, but the supplies may not be used as regulator,
Hm? What does it mean in terms of hardware?
> we mark them as required, is it OK?
How codec driver can work without power?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-10 8:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 3:56 [PATCH v1 0/4] ASoC: codecs: Add support for FourSemi FS2104/5S Nick
2025-07-03 3:56 ` [PATCH v1 1/4] ASoC: codecs: Add library for FourSemi audio amplifiers Nick
2025-07-03 3:56 ` [PATCH v1 2/4] ASoC: codecs: Add FourSemi FS2104/5S audio amplifier driver Nick
2025-07-03 14:59 ` Mark Brown
2025-07-04 11:12 ` Nick Li
2025-07-04 14:37 ` Mark Brown
2025-07-07 8:34 ` Nick Li
2025-07-07 20:42 ` Mark Brown
2025-07-03 3:56 ` [PATCH v1 3/4] ASoC: dt-bindings: Add dt bindings for FS2104/5S audio amplifiers Nick
2025-07-03 5:48 ` Rob Herring (Arm)
2025-07-03 6:36 ` Krzysztof Kozlowski
2025-07-04 6:00 ` Nick Li
2025-07-03 7:10 ` Krzysztof Kozlowski
2025-07-03 7:15 ` Krzysztof Kozlowski
2025-07-04 7:26 ` Nick Li
2025-07-04 7:18 ` Nick Li
2025-07-03 3:56 ` [PATCH v1 4/4] dt-bindings: vendor-prefixes: Add Shanghai FourSemi Semiconductor Co.,Ltd Nick
2025-07-03 5:48 ` Rob Herring (Arm)
2025-07-08 11:28 ` [PATCH v2 0/4] ASoC: codecs: Add support for FourSemi FS2104/5S Nick Li
2025-07-08 11:28 ` [PATCH v2 1/4] dt-bindings: vendor-prefixes: Add Shanghai FourSemi Semiconductor Co.,Ltd Nick Li
2025-07-09 10:36 ` Krzysztof Kozlowski
2025-07-08 11:28 ` [PATCH v2 2/4] ASoC: dt-bindings: Add schema for FS2104/5S audio amplifiers Nick Li
2025-07-09 10:40 ` Krzysztof Kozlowski
2025-07-10 8:11 ` Nick Li
2025-07-10 8:27 ` Krzysztof Kozlowski [this message]
2025-07-10 9:26 ` Nick Li
2025-07-09 10:42 ` Krzysztof Kozlowski
2025-07-10 8:02 ` Nick Li
2025-07-08 11:29 ` [PATCH v2 3/4] ASoC: codecs: Add library for FourSemi " Nick Li
2025-07-08 11:29 ` [PATCH v2 4/4] ASoC: codecs: Add FourSemi FS2104/5S audio amplifier driver Nick Li
2025-07-09 10:55 ` Krzysztof Kozlowski
2025-07-10 7:56 ` Nick Li
2025-07-10 8:27 ` Krzysztof Kozlowski
2025-07-10 11:20 ` Nick Li
2025-07-09 11:29 ` Mark Brown
2025-07-10 8:57 ` Nick Li
2025-07-10 9:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bb34074-8ce0-4f0e-b7c7-1d77a8cd6ea3@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=danyang.zheng@foursemi.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=like.xy@foxmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nick.li@foursemi.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=xiaoming.yang@foursemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.