All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.ibm.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Thomas Huth <thuth@redhat.com>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Ani Sinha <anisinha@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 5/5] hw/tpm: Simplify tpm_ppi_enabled()
Date: Tue, 17 Mar 2026 09:21:53 -0400	[thread overview]
Message-ID: <3bbaa555-bc16-4626-ac3b-338f8c9fa858@linux.ibm.com> (raw)
In-Reply-To: <20260317120241.16320-6-philmd@linaro.org>



On 3/17/26 8:02 AM, Philippe Mathieu-Daudé wrote:
> TPM instances don't expose any "ppi" property anymore,
> remove that dead code.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/system/tpm.h | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/include/system/tpm.h b/include/system/tpm.h
> index 9458ad6668a..874068d19a9 100644
> --- a/include/system/tpm.h
> +++ b/include/system/tpm.h
> @@ -13,7 +13,6 @@
>   #define QEMU_TPM_H
>   
>   #include "qapi/qapi-types-tpm.h"
> -#include "qapi/error.h"
>   #include "qom/object.h"
>   
>   #ifdef CONFIG_TPM
> @@ -85,10 +84,7 @@ static inline bool tpm_ppi_enabled(TPMIf *ti)
>       if (!ti) {
>           return false;
>       }
> -    if (TPM_IF_GET_CLASS(ti)->ppi_enabled) {
> -        return true;
> -    }
> -    return object_property_get_bool(OBJECT(ti), "ppi", &error_abort);
> +    return TPM_IF_GET_CLASS(ti)->ppi_enabled;
>   }
>   
>   #else /* CONFIG_TPM */

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>



  reply	other threads:[~2026-03-17 13:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 12:02 [PATCH v3 0/5] hw/tpm: Remove instance @ppi_enabled field Philippe Mathieu-Daudé
2026-03-17 12:02 ` [PATCH v3 1/5] hw/tpm: Factor tpm_ppi_enabled() out Philippe Mathieu-Daudé
2026-03-17 13:18   ` Stefan Berger
2026-03-17 12:02 ` [PATCH v3 2/5] hw/tpm: Add TPMIfClass::ppi_enabled field Philippe Mathieu-Daudé
2026-03-17 13:17   ` Stefan Berger
2026-03-17 15:15     ` Philippe Mathieu-Daudé
2026-03-17 12:02 ` [PATCH v3 3/5] hw/tpm: Remove CRBState::ppi_enabled field Philippe Mathieu-Daudé
2026-03-17 13:19   ` Stefan Berger
2026-03-17 15:16     ` Philippe Mathieu-Daudé
2026-03-17 16:58       ` Stefan Berger
2026-03-17 12:02 ` [PATCH v3 4/5] hw/tpm: Propagate @ppi_enabled to tpm_tis_reset() and remove in TPMState Philippe Mathieu-Daudé
2026-03-17 13:21   ` Stefan Berger
2026-03-17 12:02 ` [PATCH v3 5/5] hw/tpm: Simplify tpm_ppi_enabled() Philippe Mathieu-Daudé
2026-03-17 13:21   ` Stefan Berger [this message]
2026-03-23  9:56 ` [PATCH v3 0/5] hw/tpm: Remove instance @ppi_enabled field Philippe Mathieu-Daudé
2026-03-27 15:18   ` Stefan Berger
2026-03-27 15:21     ` Stefan Berger
2026-03-27 18:17       ` Stefan Berger
2026-03-27 23:37         ` Philippe Mathieu-Daudé
2026-04-20 20:31           ` Philippe Mathieu-Daudé
2026-04-21 21:44             ` Stefan Berger
2026-04-21 22:15               ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bbaa555-bc16-4626-ac3b-338f8c9fa858@linux.ibm.com \
    --to=stefanb@linux.ibm.com \
    --cc=anisinha@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.