All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexis Lothoré" <alexis.lothore@bootlin.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	Openembedded-core@lists.openembedded.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [OE-Core][PATCH 1/4] testimage: create a list of failed test post actions
Date: Wed, 21 Feb 2024 08:53:47 +0100	[thread overview]
Message-ID: <3be76c2c-463d-4125-8182-93113ab6efa7@bootlin.com> (raw)
In-Reply-To: <a57a3202b513da93b8b3a9571de922787a455328.camel@linuxfoundation.org>

Hello Richard,

On 2/21/24 08:34, Richard Purdie wrote:
> On Tue, 2024-02-20 at 21:01 +0100, Alexis Lothoré via
> lists.openembedded.org wrote:
>> From: Alexis Lothoré <alexis.lothore@bootlin.com>

[...]

>> +##################################################################
>> +# General post actions runner
>> +##################################################################
>> +
>> +def run_failed_tests_post_actions(d, tc):
>> +    post_actions=[
>> +        list_and_fetch_failed_tests_artifacts
>> +    ]
>> +
>> +    for action in post_actions:
>> +        action(d, tc)
> 
> Rather than create a bbclass class of python functions, these should
> move to lib/oe and become a proper python library file?

ACK, I will do that and create a proper python file for this.

> Moving functions out of the class files is on my long term todo list so
> this seems like an idea opportunity.

So should this series take the opportunity to move all already existing python
functions from testimage to a lib ? I can certainly do that if that's your point :)

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2024-02-21  7:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20 20:01 [OE-Core][PATCH 0/4] testimage: add failed test post actions and fetch more data Alexis Lothoré
2024-02-20 20:01 ` [OE-Core][PATCH 1/4] testimage: create a list of failed test post actions Alexis Lothoré
2024-02-21  7:34   ` Richard Purdie
2024-02-21  7:53     ` Alexis Lothoré [this message]
2024-02-21  7:56       ` Richard Purdie
2024-02-21  7:59         ` Alexis Lothoré
2024-02-20 20:01 ` [OE-Core][PATCH 2/4] testimage: isolate artifacts directory creation in dedicated post action Alexis Lothoré
2024-02-20 20:01 ` [OE-Core][PATCH 3/4] testimage: add target disk usage stat as " Alexis Lothoré
2024-02-20 20:01 ` [OE-Core][PATCH 4/4] testimage: add host " Alexis Lothoré

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3be76c2c-463d-4125-8182-93113ab6efa7@bootlin.com \
    --to=alexis.lothore@bootlin.com \
    --cc=Openembedded-core@lists.openembedded.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.