From: Jonas Gorski <jonas.gorski@gmail.com>
To: Daniel Golle <daniel@makrotopia.org>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Frank Wunderlich <frankwu@gmx.de>, Chad Monroe <chad@monroe.io>,
Cezary Wilmanski <cezary.wilmanski@adtran.com>,
Liang Xu <lxu@maxlinear.com>,
"Benny (Ying-Tsan) Weng" <yweng@maxlinear.com>,
Jose Maria Verdu Munoz <jverdu@maxlinear.com>,
Avinash Jayaraman <ajayaraman@maxlinear.com>,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH net-next 1/2] dsa: tag_mxl862xx: set dsa_default_offload_fwd_mark()
Date: Sat, 7 Mar 2026 10:57:56 +0100 [thread overview]
Message-ID: <3bee5ef1-0692-4779-832f-193017810c38@gmail.com> (raw)
In-Reply-To: <d9d8e6058e635c1fdd4689c875204d48d0235295.1772853341.git.daniel@makrotopia.org>
Hi,
On 07/03/2026 04:30, Daniel Golle wrote:
> The MxL862xx offloads forwarding between bridged ports to the
> hardware, so set dsa_default_offload_fwd_mark() to avoid duplicate
> forwarding of packets of (eg. flooded) frames arriving at the CPU
> port.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> net/dsa/tag_mxl862xx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/dsa/tag_mxl862xx.c b/net/dsa/tag_mxl862xx.c
> index 01f2158682718..c02f69de61cbb 100644
> --- a/net/dsa/tag_mxl862xx.c
> +++ b/net/dsa/tag_mxl862xx.c
> @@ -92,6 +92,8 @@ static struct sk_buff *mxl862_tag_rcv(struct sk_buff *skb,
> skb_pull_rcsum(skb, MXL862_HEADER_LEN);
> dsa_strip_etype_header(skb, MXL862_HEADER_LEN);
>
> + dsa_default_offload_fwd_mark(skb);
Does the switch (by default) also flood link local traffic (e.g. STP, LACP,
etc)? If not, you should not mark these as fwd offloaded.
Is there is a bit in the header that says whether a packet was flooded or
trapped that you can check?
Best regards,
Jonas
next prev parent reply other threads:[~2026-03-07 9:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 3:29 [PATCH net-next 0/2] net: dsa: mxl862xx: add support for bridge offloading Daniel Golle
2026-03-07 3:30 ` [PATCH net-next 1/2] dsa: tag_mxl862xx: set dsa_default_offload_fwd_mark() Daniel Golle
2026-03-07 9:57 ` Jonas Gorski [this message]
2026-03-08 15:18 ` Daniel Golle
2026-03-08 20:15 ` Jonas Gorski
2026-03-09 0:02 ` Daniel Golle
2026-03-09 8:07 ` Jonas Gorski
2026-03-09 12:23 ` Daniel Golle
2026-03-09 23:33 ` Vladimir Oltean
2026-03-07 3:31 ` [PATCH net-next 2/2] net: dsa: mxl862xx: implement bridge offloading Daniel Golle
2026-03-09 23:22 ` Jakub Kicinski
2026-03-09 23:27 ` Vladimir Oltean
2026-03-07 3:39 ` [PATCH net-next 0/2] net: dsa: mxl862xx: add support for " Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bee5ef1-0692-4779-832f-193017810c38@gmail.com \
--to=jonas.gorski@gmail.com \
--cc=ajayaraman@maxlinear.com \
--cc=andrew@lunn.ch \
--cc=cezary.wilmanski@adtran.com \
--cc=chad@monroe.io \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frankwu@gmx.de \
--cc=horms@kernel.org \
--cc=john@phrozen.org \
--cc=jverdu@maxlinear.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=yweng@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.