All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Sameer Pujar <spujar@nvidia.com>,
	perex@perex.cz, tiwai@suse.com, broonie@kernel.org
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 2/5] ALSA: hda: Add api to program stripe control bits
Date: Mon, 14 Jan 2019 11:28:43 -0600	[thread overview]
Message-ID: <3c0d78dc-44a2-bf72-257b-e89cd309288d@linux.intel.com> (raw)
In-Reply-To: <99e9230d-9e23-d79d-005f-9396f7d219c1@nvidia.com>


>>> +    /* following is from HD audio spec */
>>> +    for (sdo_line = max_sdo_lines; sdo_line > 0; sdo_line >>= 1) {
>>> +        if (rate > 48000)
>>> +            value = (channels * bits_per_sample *
>>> +                    (rate / 48000)) / sdo_line;
>>> +        else
>>> +            value = channels * bits_per_sample / sdo_line;
>> (channels * bit_per_sample) / sdo_line as in the spec?
>
> Though I have not used explicit braces, but as per operator precedence 
> it will be treated the same way as it is mentioned in spec.
> Let me know if you want this to be explicitly mentioned.

If you implement a spec it's better to either follow it verbatim or add 
a comment when you optimize parts away, that way reviewers understand 
your intent without having to refer to email archives. if you want to 
resend a v3 please add my tag for the series:

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Thanks!


_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-01-14 17:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11 17:22 [PATCH v2 0/5] Stripe control functionality Sameer Pujar
2019-01-11 17:22 ` [PATCH v2 1/5] ALSA: hda: add verbs for stripe control Sameer Pujar
2019-01-11 17:22 ` [PATCH v2 2/5] ALSA: hda: Add api to program stripe control bits Sameer Pujar
2019-01-11 17:55   ` Pierre-Louis Bossart
2019-01-12  6:47     ` Sameer Pujar
2019-01-14 17:28       ` Pierre-Louis Bossart [this message]
2019-01-11 17:22 ` [PATCH v2 3/5] ALSA: hda: add register offset for stripe control Sameer Pujar
2019-01-11 17:22 ` [PATCH v2 4/5] ALSA: hda: program stripe bits for controller Sameer Pujar
2019-01-11 17:22 ` [PATCH v2 5/5] ALSA: hda: program stripe control for codec Sameer Pujar
2019-01-11 18:02 ` [PATCH v2 0/5] Stripe control functionality Pierre-Louis Bossart
2019-01-12  6:31   ` Sameer Pujar
2019-01-14 17:40     ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c0d78dc-44a2-bf72-257b-e89cd309288d@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=perex@perex.cz \
    --cc=spujar@nvidia.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.